feat(fasta): add lightweight FASTA file format support#7923
Open
behroozazarkhalili wants to merge 2 commits into
Open
feat(fasta): add lightweight FASTA file format support#7923behroozazarkhalili wants to merge 2 commits into
behroozazarkhalili wants to merge 2 commits into
Conversation
Add native support for loading FASTA biological sequence files with zero external dependencies. This addresses feedback from PR huggingface#7851. Key features: - Pure Python parser based on Heng Li's readfq.py (no BioPython dependency) - Uses pa.large_string() for sequences to handle UTF-8 overflow with long genomes - Adaptive byte-based batching (max_batch_bytes=256MB) prevents Parquet page size errors with very large sequences like complete viral genomes - Supports gzip, bzip2, and xz compression via magic byte detection - Column filtering: select subset of [id, description, sequence] Supported extensions: .fa, .fasta, .fna, .ffn, .faa, .frn
FastaConfig was missing the __post_init__ method that calls super().__post_init__(). This is required to inherit BuilderConfig's validation for: - Invalid config name characters (InvalidConfigName) - data_files type validation (ValueError) This aligns with the pattern used in ArrowConfig, MmcifFolderConfig, and other packaged module configs. Also includes minor style formatting from ruff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for loading FASTA files directly with
load_dataset(), addressing feedback from #7851.FASTA is a text-based format for representing nucleotide sequences (DNA/RNA) or peptide sequences (proteins), widely used in bioinformatics.
Key Features
large_stringArrow type to handle viral genomes and long sequences (fixes UTF-8 overflow)max_batch_bytesparameter (default 256MB) prevents Parquet page size errors with very large sequencesTechnical Decisions (Addressing #7851 Feedback)
pa.large_string()for sequence columnmax_batch_bytesColumns
id>)descriptionsequenceSupported Extensions
.fa,.fasta,.fna,.ffn,.faa,.frn(and compressed variants)Usage
Test Plan
large_stringtypemax_batch_bytes)All 22 tests passing.
cc: @georgia-hf