Skip to content

GH-560: Add encoding='utf-8' to fix "UnicodeDecodeError" (Sourcery refactored) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sourcery-ai wants to merge 1 commit into
base: sourcery/master
Choose a base branch
from
Open

GH-560: Add encoding='utf-8' to fix "UnicodeDecodeError" (Sourcery refactored) #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions underthesea/datasets/uit_absa_hotel/uit_absa_hotel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,13 @@ def encode(self, labels):
if type(labels) == list:
return [self.encode(label) for label in labels]
label = labels # label is a string
if label not in self.label2index:
index = self.vocab_size
self.label2index[label] = index
self.index2label[index] = label
self.vocab_size += 1
return index
else:
if label in self.label2index:
return self.label2index[label]
index = self.vocab_size
self.label2index[label] = index
self.index2label[index] = label
self.vocab_size += 1
return index
Comment on lines +25 to +31

@sourcery-ai sourcery-ai Bot Aug 22, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function LabelEncoder.encode refactored with the following changes:



class UITABSAHotel:
Expand All @@ -41,7 +40,7 @@ def __init__(self, training="aspect"):
train_file = join(DATASETS_FOLDER, UITABSAHotel.NAME, "Train_Hotel.txt")
dev_file = join(DATASETS_FOLDER, UITABSAHotel.NAME, "Dev_Hotel.txt")
test_file = join(DATASETS_FOLDER, UITABSAHotel.NAME, "Test_Hotel.txt")
print("Currently training: %s (aspect or polarity)" % training)
print(f"Currently training: {training} (aspect or polarity)")
Comment on lines +44 to +43

@sourcery-ai sourcery-ai Bot Aug 22, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function UITABSAHotel.__init__ refactored with the following changes:


self.training = training # aspect or polarity
self.label_encoder = LabelEncoder()
Expand Down
15 changes: 7 additions & 8 deletions underthesea/datasets/uit_absa_restaurant/uit_absa_restaurant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,13 @@ def encode(self, labels):
if type(labels) == list:
return [self.encode(label) for label in labels]
label = labels # label is a string
if label not in self.label2index:
index = self.vocab_size
self.label2index[label] = index
self.index2label[index] = label
self.vocab_size += 1
return index
else:
if label in self.label2index:
return self.label2index[label]
index = self.vocab_size
self.label2index[label] = index
self.index2label[index] = label
self.vocab_size += 1
return index
Comment on lines +25 to +31

@sourcery-ai sourcery-ai Bot Aug 22, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function LabelEncoder.encode refactored with the following changes:



class UITABSARestaurant:
Expand All @@ -41,7 +40,7 @@ def __init__(self, training="aspect"):
train_file = join(DATASETS_FOLDER, UITABSARestaurant.NAME, "Train.txt")
dev_file = join(DATASETS_FOLDER, UITABSARestaurant.NAME, "Dev.txt")
test_file = join(DATASETS_FOLDER, UITABSARestaurant.NAME, "Test.txt")
print("Currently training: %s (aspect or polarity)" % training)
print(f"Currently training: {training} (aspect or polarity)")
Comment on lines +44 to +43

@sourcery-ai sourcery-ai Bot Aug 22, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function UITABSARestaurant.__init__ refactored with the following changes:


self.training = training # aspect or polarity
self.label_encoder = LabelEncoder()
Expand Down