Update integration test#85
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a9d6262. Configure here.
| - name: PR placeholder | ||
| if: github.event_name == 'pull_request' | ||
| run: echo "Integration tests run only in the merge queue." |
There was a problem hiding this comment.
🔴 "PR placeholder" step is dead code because pull_request trigger is missing from on: block
The "PR placeholder" step (line 21-23) checks if: github.event_name == 'pull_request', but the workflow's on: block (lines 3-6) only defines merge_group and workflow_dispatch triggers — there is no pull_request trigger. This means the placeholder step will never execute. If the intent was to provide a passing check for PRs (so a required status check doesn't block them), this doesn't work because the workflow simply never runs on pull_request events. The pull_request trigger needs to be added to the on: block for the placeholder to serve its purpose.
Prompt for agents
The workflow at .github/workflows/integration-tests.yml adds a "PR placeholder" step with condition `if: github.event_name == 'pull_request'`, but the workflow's `on:` trigger block (lines 3-6) does not include `pull_request`. As a result, this step is dead code — the workflow never runs on pull_request events, so the placeholder never executes.
If the goal is to provide a green/passing check for PRs (common pattern when a check is required but real work only runs in merge_group), add `pull_request:` to the `on:` trigger block. For example:
on:
pull_request:
merge_group:
types: [checks_requested]
workflow_dispatch:
This will cause the workflow to trigger on PRs, at which point the placeholder step will run and the real steps (guarded by the merge_group/workflow_dispatch condition) will be skipped.
If the placeholder was added by mistake and is not needed, simply remove the PR placeholder step and the now-redundant `if` conditions on all other steps.
Was this helpful? React with 👍 or 👎 to provide feedback.

Note
Low Risk
Low risk workflow-only change; main impact is CI behavior, potentially skipping integration coverage on PRs if merge queue isn’t used as expected.
Overview
Integration test workflow is updated to trigger on
pull_requestbut only emit a placeholder message, while the real integration test job runs only formerge_group(merge queue) andworkflow_dispatchevents.The job now runs on
ubuntu-24.04(instead of the custom runner) and adds apoetry buildstep before executingpytestintegration tests.Reviewed by Cursor Bugbot for commit 812fa02. Bugbot is set up for automated code reviews on this repo. Configure here.