Skip to content

Update integration test#85

Merged
AHarmlessPyro merged 2 commits into
mainfrom
int_test_fix
May 15, 2026
Merged

Update integration test#85
AHarmlessPyro merged 2 commits into
mainfrom
int_test_fix

Conversation

@AHarmlessPyro
Copy link
Copy Markdown
Contributor

@AHarmlessPyro AHarmlessPyro commented May 15, 2026

Note

Low Risk
Low risk workflow-only change; main impact is CI behavior, potentially skipping integration coverage on PRs if merge queue isn’t used as expected.

Overview
Integration test workflow is updated to trigger on pull_request but only emit a placeholder message, while the real integration test job runs only for merge_group (merge queue) and workflow_dispatch events.

The job now runs on ubuntu-24.04 (instead of the custom runner) and adds a poetry build step before executing pytest integration tests.

Reviewed by Cursor Bugbot for commit 812fa02. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a9d6262. Configure here.

Comment thread .github/workflows/integration-tests.yml
Comment thread .github/workflows/integration-tests.yml Outdated
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment on lines +21 to +23
- name: PR placeholder
if: github.event_name == 'pull_request'
run: echo "Integration tests run only in the merge queue."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 "PR placeholder" step is dead code because pull_request trigger is missing from on: block

The "PR placeholder" step (line 21-23) checks if: github.event_name == 'pull_request', but the workflow's on: block (lines 3-6) only defines merge_group and workflow_dispatch triggers — there is no pull_request trigger. This means the placeholder step will never execute. If the intent was to provide a passing check for PRs (so a required status check doesn't block them), this doesn't work because the workflow simply never runs on pull_request events. The pull_request trigger needs to be added to the on: block for the placeholder to serve its purpose.

Prompt for agents
The workflow at .github/workflows/integration-tests.yml adds a "PR placeholder" step with condition `if: github.event_name == 'pull_request'`, but the workflow's `on:` trigger block (lines 3-6) does not include `pull_request`. As a result, this step is dead code — the workflow never runs on pull_request events, so the placeholder never executes.

If the goal is to provide a green/passing check for PRs (common pattern when a check is required but real work only runs in merge_group), add `pull_request:` to the `on:` trigger block. For example:

on:
  pull_request:
  merge_group:
    types: [checks_requested]
  workflow_dispatch:

This will cause the workflow to trigger on PRs, at which point the placeholder step will run and the real steps (guarded by the merge_group/workflow_dispatch condition) will be skipped.

If the placeholder was added by mistake and is not needed, simply remove the PR placeholder step and the now-redundant `if` conditions on all other steps.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@AHarmlessPyro AHarmlessPyro merged commit 29e860b into main May 15, 2026
2 checks passed
@AHarmlessPyro AHarmlessPyro deleted the int_test_fix branch May 15, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants