Skip to content

Update integration test #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AHarmlessPyro merged 2 commits into from
May 15, 2026
Merged

Update integration test #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d6262
Update integration test
AHarmlessPyro May 15, 2026
812fa02
Fix stuff
AHarmlessPyro May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Integration Tests

on:
pull_request:
branches: [main]
merge_group:
types: [checks_requested]
workflow_dispatch:
Expand All @@ -14,27 +16,42 @@ permissions:

jobs:
integration-tests:
runs-on: depot-ubuntu-24.04-16
name: integration-tests
runs-on: ubuntu-24.04

steps:
- name: PR placeholder
if: github.event_name == 'pull_request'
run: echo "Integration tests run only in the merge queue."
Comment on lines +23 to +25
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 "PR placeholder" step is dead code because pull_request trigger is missing from on: block

The "PR placeholder" step (line 21-23) checks if: github.event_name == 'pull_request', but the workflow's on: block (lines 3-6) only defines merge_group and workflow_dispatch triggers — there is no pull_request trigger. This means the placeholder step will never execute. If the intent was to provide a passing check for PRs (so a required status check doesn't block them), this doesn't work because the workflow simply never runs on pull_request events. The pull_request trigger needs to be added to the on: block for the placeholder to serve its purpose.

Prompt for agents 
The workflow at .github/workflows/integration-tests.yml adds a "PR placeholder" step with condition `if: github.event_name == 'pull_request'`, but the workflow's `on:` trigger block (lines 3-6) does not include `pull_request`. As a result, this step is dead code — the workflow never runs on pull_request events, so the placeholder never executes.

If the goal is to provide a green/passing check for PRs (common pattern when a check is required but real work only runs in merge_group), add `pull_request:` to the `on:` trigger block. For example:

on:
  pull_request:
  merge_group:
    types: [checks_requested]
  workflow_dispatch:

This will cause the workflow to trigger on PRs, at which point the placeholder step will run and the real steps (guarded by the merge_group/workflow_dispatch condition) will be skipped.

If the placeholder was added by mistake and is not needed, simply remove the PR placeholder step and the now-redundant `if` conditions on all other steps.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread
cursor[bot] marked this conversation as resolved.

- name: Check out repository
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
uses: actions/checkout@v6

- name: Set up Python
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
uses: actions/setup-python@v6
with:
python-version: "3.12"

- name: Install Poetry
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
run: python -m pip install --upgrade pip poetry

- name: Show tool versions
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
run: |
python --version
poetry --version

- name: Install dependencies
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
run: poetry install --with dev --no-interaction

- name: Build package
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
run: poetry build

- name: Run integration tests
if: github.event_name == 'merge_group' || github.event_name == 'workflow_dispatch'
run: poetry run pytest tests/integration