style(ncl): format Nickel files with nickel format - #106
Merged
Merged
Conversation
All 11 genuine Nickel files failed `nickel format --check`, so the ci-pipeline Nickel gate reported a real defect once it stopped also failing over `*.k9.ncl` k9 contracts (hyperpolymath/standards#985). Formatting only. Verified semantics-preserving by comparing the parsed AST: `nickel pprint-ast` output is byte-identical for 11 of 11 files before and after. SPDX and copyright headers are unchanged, and the total comment-line count is identical (353 before, 353 after). Run with the pipeline's own pinned nickel 1.18.0 (sha256-verified), not a local build, because formatter output differs between releases. No CI auto-fix is involved: this is a deliberate commit, and the pipeline still runs `--check` only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ji1bq3TypfycfUPAR7hSxR
Contributor
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
hyperpolymath
added a commit
to hyperpolymath/rsr-template-repo
that referenced
this pull request
Sep 22, 2026
Formatting only — all 11 genuine Nickel files in the template fail `nickel format --check`. **This is where the defect originates.** Every repo seeded from this template inherits these files, so each one goes red on the ci-pipeline Nickel gate over boilerplate it did not write. `cicd-squabbler` is the measured case (hyperpolymath/cicd-squabbler#106) — it went 100% red on template files, never on its own source. Fixing the template stops the defect propagating to new seeds. The other half of that red was a defect in the shared gate itself, fixed in hyperpolymath/standards#985: it globbed `*.ncl`, so it also checked the 18 `*.k9.ncl` **k9 contracts** here — a different format (`K9!` sentinel on line 1) that can never pass `nickel typecheck`. Those 18 files are untouched by this PR. ## Verification Run with the pipeline's **own pinned nickel 1.18.0** (sha256-verified from the workflow), not a local build — formatter output differs between releases. | control | result | |---|---| | `nickel pprint-ast` byte-identical before vs after | **11 / 11** | | SPDX + copyright headers unchanged | 11 / 11 | | total comment lines | 356 before, 356 after | | files touched outside genuine `*.ncl` | 0 | | `nickel format --check` after | passes on all 11 | The AST comparison is the point: this is provably a cosmetic reformat, not a semantic change. ## Not an auto-fix No `--fix` runs in CI. The pipeline still uses `--check` only; this is a deliberate commit in a reviewable PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ji1bq3TypfycfUPAR7hSxR Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting only — all 11 genuine Nickel files in this repo fail
nickel format --check.This is the repo's own half of the Nickel red. The other half was a defect in
the shared gate, fixed in hyperpolymath/standards#985: it globbed
*.ncland soalso checked the 16
*.k9.nclk9 contracts, which are a different format(
K9!sentinel on line 1) and can never pass. With that gate fix alone this repowould still be red, on these 11 files, legitimately.
Verification
Run with the pipeline's own pinned nickel 1.18.0 (sha256-verified from the
workflow), not a local build — formatter output differs between releases.
nickel pprint-astbyte-identical before vs after*.nclnickel format --checkafterThe AST comparison is the point: this is provably a cosmetic reformat, not a
semantic change.
Not an auto-fix
No
--fixruns in CI. The pipeline still uses--checkonly; this is adeliberate commit in a reviewable PR.
Remaining
Once standards#985 merges, this repo's caller needs re-pinning to that squash
SHA. Until then the pipeline check here still runs the old gate and will stay
red on the k9 contracts — that is expected and is not caused by this PR.
The 2 files importing build-time JSON (
claude-md-data.json,clauses.json)remain un-typecheckable standalone by design; standards#985 skips them and
discloses each skip by name rather than pretending to check them.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ji1bq3TypfycfUPAR7hSxR