fix(ffp): unconflict #126 onto main and repair the errors hiding behind its syntax fix (#122)

[hyperpolymath]

Fixes the conflicted merge in #126, and completes the CI repair for #122.

1. The merge conflict, resolved

#126's branch still carries fa14610 — the same tree that reached main as the #125 merge commit (eb98112) — so GitHub cannot three-way-merge it (CONFLICTING). fa14610's tree is byte-identical to main's tip, so this branch replays #126's three unique commits cleanly on top of main (verified: git diff fa14610 origin/main is empty; the cherry-picks applied without a single conflict). This PR's final tree is therefore #126's intended end-state, rebased.

Because this session's branch is arena/01a108e5-presswerk, the rebased result lives here rather than on #126's branch; this PR supersedes #126, which should be closed.

2. What #126's syntax fix unblocked — and what this PR repairs on top

The syntax error in presswerk-document/src/provenance.rs had stopped rustc at parse stage, so nothing behind it was ever compiled or tested. After applying #126's fixes, a line-by-line audit against the pinned lopdf 0.40 source found and fixed:

Compile errors

• object_to_string matched Object::Integer64 — a variant that does not exist in lopdf 0.40 (Integer already carries i64). Removed.

Test bugs (fixtures shaped unlike real viewer output)

• The "hand/viewer-filled" fixtures in the detector unit tests and the IPP-server tests used /AP << /N null >>. The detector counts that as a missing appearance, so viewer_filled_is_unknown would see Incomplete where it asserts Generated, and the blank-print hazard (appearances == incomplete && filled > 0) would hold the hand-filled job that hold_policy_leaves_hand_filled_form_alone expects to stay Pending. Both fixtures now carry a real appearance stream — the shape of the conformance viewer-filled vector.

Appearance semantics

• /N resolution rewritten (state_appearance_exists): a stream is an appearance; a state-keyed dictionary requires the current state (/AS, falling back to a name /V) to select an entry. This also removes an unread n_resolved binding from a match whose arms all return.

Clippy cleanliness (CI runs clippy --workspace --all-targets -- -D warnings)

• Removed unused variables: xmp_found, xmp_unreadable, payload_s (detector), is_machine_or_suspected (jobs page).
• walk_field had nine parameters plus a never-written evidence parameter → now takes an Inherited { ft, ff, v } struct (six parameters).
• .map(|o| object_to_string(o)) → .map(object_to_string); dropped a redundant else after a diverging if, the duplicated pushbutton parse + dead parse_ff, and the dead resolve_array helper.
• FfpClassification::from_str carries #[allow(clippy::should_implement_trait)] with a comment: the token vocabulary deliberately never fails to parse (unknown → Unreadable), mirroring from_token.
• row_to_print_job: collapsed two identical if branches.

Misc

• The %PDF- pre-check in classify_document was an empty if block; it now does what its comment promised (returns unreadable when raw bytes are present and lack the header). No vector outcome changes — classify_pdf already failed such input at lopdf::load_mem.
• Fixed a doc comment in pdf/reader.rs containing leaked literal \n escapes.

3. Conformance status (#122, criterion 2)

All 14 FFP v1.0.0 conformance vectors were traced by hand through the detector against probe.awk and make-fixtures.sh in hyperpolymath/standards (spec now merged to main, 1-formats/sub-specs/form-fill-provenance/spec/conformance/): each vector's expected canonical line matches the detector's code path, including the negative controls (blank-form-need-appearances → blank-form, viewer-filled → filled-unknown, unreadable → unreadable via load_mem failure). just ffp-conformance (FFP_DETECTOR=./target/debug/ffp-classify bash …/run-conformance.sh) runs the real 14/14 check wherever a standards checkout is available.

Resolves #122
Supersedes #126

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: b8b8cbdb-5451-4679-ae88-422bd111c746

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}