fix(lark): allow null user_id in group message mentions - #907
Open
yunhis wants to merge 1 commit into
Open
Conversation
Feishu group messages set mentions[].id.user_id to null when the bot is mentioned, which made serde fail to deserialize the whole MessageEvent (invalid type: null, expected a string) and silently dropped the message. Reuse the existing deserialize_nullable_string helper (already used by SenderIdContainer) for MentionId fields, and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feishu group messages set mentions[].id.user_id to null when the bot is mentioned, which made serde fail to deserialize the whole MessageEvent (invalid type: null, expected a string) and silently dropped the message. Reuse the existing deserialize_nullable_string helper (already used by SenderIdContainer) for MentionId fields, and add a regression test.