Skip to content

fix(lark): allow null user_id in group message mentions #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yunhis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lark): allow null user_id in group message mentions #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions crates/aionui-channel/src/plugins/lark/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,11 @@ pub(crate) struct Mention {
#[derive(Debug, Clone, Deserialize)]
#[allow(dead_code)]
pub(crate) struct MentionId {
#[serde(default)]
#[serde(default, deserialize_with = "deserialize_nullable_string")]
pub open_id: String,
#[serde(default)]
#[serde(default, deserialize_with = "deserialize_nullable_string")]
pub user_id: String,
#[serde(default)]
#[serde(default, deserialize_with = "deserialize_nullable_string")]
pub union_id: String,
}

Expand Down Expand Up @@ -558,6 +558,37 @@ mod tests {
assert_eq!(mentions[0].name, "MyBot");
}

#[test]
fn message_event_with_null_mention_user_id_parses() {
let raw = json!({
"sender": {
"sender_id": { "open_id": "ou_user2", "user_id": "", "union_id": "" },
"sender_type": "user",
"tenant_key": "tk_1"
},
"message": {
"message_id": "om_msg3",
"chat_id": "oc_chat3",
"chat_type": "group",
"message_type": "text",
"content": "{\"text\":\"@_user_1 Hello\"}",
"mentions": [
{
"key": "@_user_1",
"id": { "open_id": "ou_bot", "user_id": null, "union_id": "" },
"name": "MyBot"
}
]
}
});
let evt: MessageEvent = serde_json::from_value(raw).unwrap();
let mentions = evt.message.mentions.unwrap();
assert_eq!(mentions.len(), 1);
assert_eq!(mentions[0].key, "@_user_1");
assert_eq!(mentions[0].id.user_id, ""); // null 被归一化为空字符串
assert_eq!(mentions[0].name, "MyBot");
}

// -- TextContent / ImageContent / FileContent ---------------------------

#[test]
Expand Down