Defer merge queue evaluation when GitHub mergeable is Unknown#728
Defer merge queue evaluation when GitHub mergeable is Unknown#728iamnbutler wants to merge 1 commit intomainfrom
Conversation
When GitHub's mergeable field is Unknown (computation pending), the reconcile_merge_queue function now sets a mergeable_unknown flag on the entry. The orchestrator's evaluation logic skips entries with this flag, preventing premature approval of PRs whose conflict status hasn't been resolved yet. The flag is automatically cleared once GitHub reports a definitive Mergeable or Conflicting status. Closes #503 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Orchestrator Evaluation: Rejected The PR has merge conflicts (Mergeable: No) and CI is failing. Beyond that, the implementation approach is reasonable — it adds a Feedback for agent: The implementation logic itself looks sound: treating
|
Summary
mergeable_unknownflag toMergeQueueEntryto track when GitHub hasn't computed mergeability yetreconcile_merge_queuenow sets this flag whenmergeableisUnknownorNone, and clears it when GitHub resolves toMergeableorConflictingneeds_evaland queue seeding) skips entries withmergeable_unknown=true, preventing premature approval of PRs whose conflict status is pendingTest plan
mergeable_unknowndefaults tofalseand entries with the flag still appear inpending()(filtering happens at orchestrator level)UnknownCloses #503
🤖 Generated with Claude Code