chore(ci): add Ruff linting workflow - #20
Merged
Merged
Conversation
Dexter9532
force-pushed
the
ruff_workflow
branch
2 times, most recently
from
October 20, 2025 08:02
9ac35dc to
4c00ef8
Compare
Closed
mirzak
requested changes
Oct 20, 2025
Contributor
|
Also your commits must be signed off, see https://stackoverflow.com/a/35238070/10612238. Related to #17 |
Dexter9532
force-pushed
the
ruff_workflow
branch
from
October 20, 2025 09:04
4c00ef8 to
e5959d7
Compare
Contributor
Author
|
i added this for testing, cause i had problem getting all checks to pass before. This version dont use 3.13 or 3.14 |
Dexter9532
force-pushed
the
ruff_workflow
branch
from
October 20, 2025 09:34
ac292e7 to
4092c1b
Compare
Dexter9532
force-pushed
the
ruff_workflow
branch
2 times, most recently
from
October 20, 2025 09:56
ac86a6b to
b3a7dc0
Compare
Contributor
Author
|
It says that there is a change requested but i can´t see? |
Contributor
Where did you find this? They claim it is supported, https://docs.astral.sh/uv/reference/policies/platforms/#python-support |
mirzak
requested changes
Oct 20, 2025
Contributor
Author
|
It does not comply now, and i cant find the error. |
Contributor
Author
|
@govnoir helped me find that i had v1 instead of v7 when i used the setup! |
Dexter9532
force-pushed
the
ruff_workflow
branch
from
October 20, 2025 12:59
4d31d44 to
11f4480
Compare
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
Dexter9532
force-pushed
the
ruff_workflow
branch
from
October 20, 2025 14:35
11f4480 to
d6e2c03
Compare
mirzak
requested changes
Oct 20, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
Now we are close, just some minor things remaining.
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
mirzak
requested changes
Oct 20, 2025
Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
mirzak
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5