Move Playlist component to mux-player-react#12
Draft
ismapin22 wants to merge 13 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
reviewed
May 6, 2025
| import Head from 'next/head'; | ||
| import '../post-video.css' | ||
| import Playlist from '../components/playlist'; | ||
| import "@mux/mux-video-ads" |
There was a problem hiding this comment.
could this import "@mux/mux-video-ads" be added in NewsweekMuxPlayer so they don't have to know about this?
luwes
reviewed
May 6, 2025
| import '../post-video.css' | ||
| import Playlist from '../components/playlist'; | ||
| import "@mux/mux-video-ads" | ||
| import { NewsweekMuxPlayer, PlaylistEndScreen } from "@mux/mux-player-react" |
There was a problem hiding this comment.
Suggested change
| import { NewsweekMuxPlayer, PlaylistEndScreen } from "@mux/mux-player-react" | |
| import { NewsweekMuxPlayer } from "@mux/mux-player-react" |
luwes
reviewed
May 6, 2025
|
|
||
| ```jsx | ||
| 'use client'; | ||
| import "@mux/mux-video-ads"; |
There was a problem hiding this comment.
Suggested change
| import "@mux/mux-video-ads"; |
I would remove this here so they don't have to think about that
luwes
reviewed
May 6, 2025
|
|
||
| ```json | ||
| "dependencies": { | ||
| "@mux/mux-player": "https://gitpkg.vercel.app/ismapin22/elements/packages/mux-player?mux-newsweek-player", |
There was a problem hiding this comment.
Suggested change
| "@mux/mux-player": "https://gitpkg.vercel.app/ismapin22/elements/packages/mux-player?mux-newsweek-player", |
this shouldn't be needed if it's a dependency of @mux/mux-player-react right?
luwes
reviewed
May 6, 2025
| "dependencies": { | ||
| "@mux/mux-player": "https://gitpkg.vercel.app/ismapin22/elements/packages/mux-player?mux-newsweek-player", | ||
| "@mux/mux-player-react": "https://gitpkg.vercel.app/ismapin22/elements/packages/mux-player-react?mux-newsweek-player", | ||
| "@mux/mux-video-ads": "https://gitpkg.vercel.app/ismapin22/elements/packages/mux-video-ads?mux-newsweek-player" |
There was a problem hiding this comment.
Suggested change
| "@mux/mux-video-ads": "https://gitpkg.vercel.app/ismapin22/elements/packages/mux-video-ads?mux-newsweek-player" |
make @mux/mux-video-ads a dependency of @mux/mux-player-react
luwes
reviewed
May 6, 2025
| 'use client'; | ||
| import Head from 'next/head'; | ||
| import { useEffect, useState } from "react"; | ||
| import "@mux/mux-video-ads"; |
There was a problem hiding this comment.
Suggested change
| import "@mux/mux-video-ads"; |
remove the need if possible
luwes
added a commit
to muxinc/elements
that referenced
this pull request
May 7, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
luwes
added a commit
to muxinc/elements
that referenced
this pull request
Jun 2, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
luwes
added a commit
to muxinc/elements
that referenced
this pull request
Jun 12, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
luwes
added a commit
to muxinc/elements
that referenced
this pull request
Jun 13, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.