Repository navigation
test: wait for the external-change watcher instead of a fixed delay - #8
Merged
Merged
Conversation
unsavedWorkIsNeverReplacedWithoutAsking checked that the reload question was pending after a fixed 0.9 s sleep. On CI's slower runners the watcher's event sometimes came later, failing main (74ff4b6, and before at 5b0a588, a docs-only commit) and PR #3. It now waits for the question with the suite's eventually helper, as its sibling tests do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExternalChangeTests.unsavedWorkIsNeverReplacedWithoutAskingchecked that the reload question was pending after a fixed 0.9 s sleep. On CI's slower runners the file watcher's event sometimes arrived later, so the test failed onmain(74ff4b6, and earlier at 5b0a588, a docs-only commit) and on #3.It now waits for the question with the suite's
eventuallyhelper, as its sibling tests already do. The tests that check that nothing happens keep their fixed wait, which is right for them.Testing:
swift test --disable-keychain --filter ExternalChangeTests, 6 passed.This branch is also merged into the open PRs so their CI passes before this one lands.