Skip to content

Repository navigation

test: wait for the external-change watcher instead of a fixed delay #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsjavi merged 1 commit into from
Oct 8, 2026
Merged

test: wait for the external-change watcher instead of a fixed delay #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Tests/CompositorTests/ExternalChangeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,10 @@ struct ExternalChangeTests {
let active = try #require(session.document?.layers.first?.id)
session.renameLayer(active, to: "Unsaved here")
try await renameFirstLayerOnDisk(url, to: "Renamed elsewhere")
await settle()
// No window to ask in, so the question waits and the document keeps the unsaved edit.
// No window to ask in, so the question waits and the document keeps the unsaved edit. Waits for the
// watcher rather than a fixed delay: on a busy machine its event can take longer than one.
#expect(await eventually { controller.externalChanges.pending })
#expect(controller.externalChanges.reloadCount == 0)
#expect(controller.externalChanges.pending)
#expect(session.document?.layers.first?.name == "Unsaved here")
#expect(session.isModified)
}
Expand Down
Loading