Escape Yosys-reserved words in Verilog#30
Open
jeet-dekivadia wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
untypedspellingdistidentifier in Verilog, SystemVerilog, and VHDL outputFixes #21
Correctness
Yosys applies its SystemVerilog keyword table while emitting Verilog. Using the same superset for Hardcaml's Verilog legalization ensures names rejected by Yosys are escaped before they reach the backend. VHDL legalization is unchanged.
Validation
git diff --checkverilog_keywords(): matched all 248 keywords with no missing or extra entries\distdeclarations and assignments while VHDL remainsdistppx_rope