fixed save_exp clipping for compatibility with newest JAX versions#802
Merged
Merged
Conversation
… from jnp.clip was deprecated)
Contributor
|
Cool, thanks for contributing this fix. Using minimum is, a nice idea. Could you add a line to the CHANGELOG.md, then I will merge this, once tests pass :) |
Contributor
Author
|
Done. Thanks to you :) |
Contributor
|
Thanks. I would prefer not make a release just for this. So if installing from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #798
Replaces the deprecated
jnp.clip(..., a_max=...)usage insave_expwithjnp.minimum.I chose to use
jnp.minimumbecause it whatjnp.clipdoes under the hood when only themaxargument is provided.No more keyword arguments, to avoid it to happen again.