Skip to content

fixed save_exp clipping for compatibility with newest JAX versions #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnsbck merged 2 commits into from
May 20, 2026
+2 −1
Merged

fixed save_exp clipping for compatibility with newest JAX versions #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66d4115
fixed solver_gate.save_exp issue with new JAX versions (keyword a_max…
lorenzosquadrani May 18, 2026
06d0766
update CHANGELOG.md for save_exp fix
lorenzosquadrani May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Implements Brette et al. (2005), 'Adaptive exponential integrate-and-fire model
- Fix issue causing some `View`s to take too long to create (#791, @alexpejovic)
- Fix single point branch plotting with type="comp" (#797, @jnsbck)
- jx.integrate took O(n^2) time with n compartments on the backwards pass. Instead of backpropagating through the forward solve, we now use a custom_jvp (another tridiagonal solve, which is O(n)) (#795 @manuelgloeckler)
- Fix compatibility with newer JAX versions by avoiding the deprecated `jnp.clip(..., a_max=...)` keyword in `solver_gate.save_exp` (#798, @lorenzosquadrani)

# 0.13.0

Expand Down
2 changes: 1 addition & 1 deletion jaxley/solver_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

def save_exp(x, max_value: float = 20.0):
"""Clip the input to a maximum value and return its exponential."""
x = jnp.clip(x, a_max=max_value)
x = jnp.minimum(x, max_value)
return jnp.exp(x)


Expand Down
Loading