Skip to content

fix(builtins): match root action metadata files in pinact globs - #1268

Draft
risu729 wants to merge 2 commits into
jdx:mainfrom
risu729:fix/pinact-root-action-glob
Draft

fix(builtins): match root action metadata files in pinact globs#1268
risu729 wants to merge 2 commits into
jdx:mainfrom
risu729:fix/pinact-root-action-glob

Conversation

@risu729

@risu729 risu729 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

The pinact and pinact_update builtins' glob List(".github/workflows/*", "*/action.*") never matches a root-level action.yml/action.yaml (standalone action repositories), because the pattern requires a / before action..

pinact's own default discovery does include root action metadata (see defaultWorkflowPatterns in pkg/controller/run/list_workflows.go: action.yml, action.yaml, and one-to-three-level-deep variants). Under hk, {{files}} replaces pinact's own discovery, so the step glob is the gate — this change restores parity for both builtins (they define the same glob independently; pinact_v3/pinact_update_v3 inherit it).

Notes:

  • hk builds step globs without literal_separator (src/glob.rs), so * already crosses / and nested files like .github/actions/setup/action.yml matched before this change; root was the only gap. **/action.* covers root and all depths.
  • types = List("yaml") composes with AND, so the widened glob still only selects YAML.
  • No test added: StepTest passes files explicitly, so glob selection is not exercised by hk test.

Supersedes #1269 (same fix for pinact_update, consolidated here since it is one logical change).

AI-assisted — Tool: Claude Code; model: anthropic/claude-fable-5; version: 2.1.241.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • pkl/builtins/pinact.pkl is excluded by !**/*.pkl
  • pkl/builtins/pinact_update.pkl is excluded by !**/*.pkl

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b0330207-3a4b-4f55-bb37-9a44e3b76958

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@risu729 risu729 changed the title fix(builtins): match root action metadata files in pinact glob fix(builtins): match root action metadata files in pinact globs Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 2 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 3 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant