fix(builtins): match root action metadata files in pinact globs - #1268
fix(builtins): match root action metadata files in pinact globs#1268risu729 wants to merge 2 commits into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 3 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
The
pinactandpinact_updatebuiltins' globList(".github/workflows/*", "*/action.*")never matches a root-levelaction.yml/action.yaml(standalone action repositories), because the pattern requires a/beforeaction..pinact's own default discovery does include root action metadata (see
defaultWorkflowPatternsinpkg/controller/run/list_workflows.go:action.yml,action.yaml, and one-to-three-level-deep variants). Under hk,{{files}}replaces pinact's own discovery, so the step glob is the gate — this change restores parity for both builtins (they define the same glob independently;pinact_v3/pinact_update_v3inherit it).Notes:
literal_separator(src/glob.rs), so*already crosses/and nested files like.github/actions/setup/action.ymlmatched before this change; root was the only gap.**/action.*covers root and all depths.types = List("yaml")composes with AND, so the widened glob still only selects YAML.StepTestpassesfilesexplicitly, so glob selection is not exercised byhk test.Supersedes #1269 (same fix for
pinact_update, consolidated here since it is one logical change).AI-assisted — Tool: Claude Code; model: anthropic/claude-fable-5; version: 2.1.241.