Skip to content

fix(builtins): match root action metadata files in pinact_update glob - #1269

Closed
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:fix/pinact-update-root-action-glob
Closed

fix(builtins): match root action metadata files in pinact_update glob#1269
risu729 wants to merge 1 commit into
jdx:mainfrom
risu729:fix/pinact-update-root-action-glob

Conversation

@risu729

@risu729 risu729 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

The pinact_update builtin's glob List(".github/workflows/*", "*/action.*") never matches a root-level action.yml/action.yaml (standalone action repositories), because the pattern requires a / before action..

pinact's own default discovery does include root action metadata (see defaultWorkflowPatterns in pkg/controller/run/list_workflows.go: action.yml, action.yaml, and one-to-three-level-deep variants). Under hk, {{files}} replaces pinact's own discovery, so the step glob is the gate — this change restores parity.

Notes:

  • hk builds step globs without literal_separator (src/glob.rs), so * already crosses / and nested files like .github/actions/setup/action.yml matched before this change; root was the only gap. **/action.* covers root and all depths.
  • types = List("yaml") composes with AND, so the widened glob still only selects YAML.
  • No test added: StepTest passes files explicitly, so glob selection is not exercised by hk test.

Sibling PR #1268 applies the same fix to the pinact builtin, which defines the same glob independently.

AI-assisted — Tool: Claude Code; model: anthropic/claude-fable-5; version: 2.1.241.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pkl/builtins/pinact_update.pkl is excluded by !**/*.pkl

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d6ea2314-2cea-4e97-a412-6f35d5f8894a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@risu729

risu729 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #1268 — one logical change across both builtins, so a single PR is simpler to review.

AI-assisted — Tool: Claude Code; model: anthropic/claude-fable-5; version: 2.1.241.

@risu729 risu729 closed this Aug 26, 2026
@risu729
risu729 deleted the fix/pinact-update-root-action-glob branch August 26, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant