Fix two clang findings: dead recv-frame helpers, DPK status test that always warned - #43
Merged
Merged
Conversation
rxmem_to_recvframe(), pkt_to_recvframe(), pkt_to_recvmem() and pkt_to_recvdata() have no callers, and pkt_to_recvframe() returns a value derived from a local that is never assigned (clang -Wuninitialized on every translation unit that includes the header). Remove them.
status != DONE || status != ERROR is always true, so every completed DPK command logged "unexpected status". Use && as the sibling cases do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clang build (LLVM=1, arm64, 7.1 headers) turned up two defects:
pkt_to_recvmem() and pkt_to_recvdata() have no callers, and
pkt_to_recvframe() derives its result from a local that is never
assigned (-Wuninitialized in every TU that includes the header). Removed.
every completed DPK command logged "unexpected status". Use && as the
sibling cases do.
gcc + clang builds: no errors; clang -Wuninitialized 152 -> 0,
-Wtautological-overlap-compare 1 -> 0, every other class unchanged.
Does not overlap #41 / #42.