Skip to content

Fix two clang findings: dead recv-frame helpers, DPK status test that always warned #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeepn merged 2 commits into from
Aug 20, 2026
Merged

Fix two clang findings: dead recv-frame helpers, DPK status test that always warned #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f58f63c
rtw_recv: drop the dead pkt/rxmem recv-frame helpers
iav Aug 16, 2026
f35e1a7
hal_halmac: warn about DPK status only when it is neither DONE nor ERROR
iav Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hal/hal_halmac.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ static inline u8 is_valid_id_status(enum halmac_feature_id id, enum halmac_cmd_p
if (status == HALMAC_CMD_PROCESS_RCVD)
return _FALSE;
if ((status != HALMAC_CMD_PROCESS_DONE)
|| (status != HALMAC_CMD_PROCESS_ERROR))
&& (status != HALMAC_CMD_PROCESS_ERROR))
RTW_WARN("%s: %s unexpected status(0x%x)!\n",
__FUNCTION__, RTW_HALMAC_FEATURE_NAME[id],
status);
Expand Down
41 changes: 0 additions & 41 deletions include/rtw_recv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,47 +759,6 @@ __inline static u8 *recvframe_pull_tail(union recv_frame *precvframe, sint sz)

}

__inline static union recv_frame *rxmem_to_recvframe(u8 *rxmem)
{
/* due to the design of 2048 bytes alignment of recv_frame, we can reference the union recv_frame */
/* from any given member of recv_frame. */
/* rxmem indicates the any member/address in recv_frame */

return (union recv_frame *)(((SIZE_PTR)rxmem >> RXFRAME_ALIGN) << RXFRAME_ALIGN);

}

__inline static union recv_frame *pkt_to_recvframe(_pkt *pkt)
{

u8 *buf_star;
union recv_frame *precv_frame;
precv_frame = rxmem_to_recvframe((unsigned char *)buf_star);

return precv_frame;
}

__inline static u8 *pkt_to_recvmem(_pkt *pkt)
{
/* return the rx_head */

union recv_frame *precv_frame = pkt_to_recvframe(pkt);

return precv_frame->u.hdr.rx_head;

}

__inline static u8 *pkt_to_recvdata(_pkt *pkt)
{
/* return the rx_data */

union recv_frame *precv_frame = pkt_to_recvframe(pkt);

return precv_frame->u.hdr.rx_data;

}


__inline static sint get_recvframe_len(union recv_frame *precvframe)
{
return precvframe->u.hdr.len;
Expand Down
Loading