refactor: extract session navigation helper#102
Open
kilo-WATT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionDetail.tsxsessionNavigationhelper for current, previous, and next session stateBehavior
No intended behavior changes.
Preserved:
/sessions/:dateroutesValidation
npm run buildfrom repo root: passednpm run buildinfrontend: passed, includingtsc -bnpm run testinfrontend: passed, 3 files / 9 testsnpm run typecheck: no script exists at root or frontendnpm run lintinfrontend: fails on existing repo-wide lint issues unrelated to this PRNotes
This PR keeps the session detail UI behavior the same while moving navigation calculation into a small helper that is easier to test and maintain.