Don't stop grpc keepalives after 5 pings

[mangelajo]

Otherwise the keepalive stops being effective and cloud
load balancers will close the connection

Summary by CodeRabbit

• Chores
  • Updated the gRPC connection settings by removing the limit on idle pings, which helps improve connection reliability and overall network communication.

[coderabbitai]

Walkthrough

The change updates the default value of the gRPC option "grpc.http2.max_pings_without_data" from 5 to 0 within the _override_default_grpc_options function. This modification disables the limit on pings sent without accompanying data, while all other gRPC configurations remain unchanged.

Changes

File(s)	Change Summary
packages/jumpstarter/.../grpc.py	Updated default "grpc.http2.max_pings_without_data" value from 5 to 0 in the helper function

Possibly related PRs

• Microshift bootc image jumpstarter#314: Modifies the same gRPC option, indicating a direct relationship between the changes.

Suggested reviewers

• NickCao

Poem

I'm a rabbit with code in my paw,
Hopping through changes without a flaw.
Tweaked the pings from five down to none,
In gRPC fields, a light new run.
A joyful hop to celebrate what we've done!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0a3c55 and 0a9b71c.

📒 Files selected for processing (1)

• packages/jumpstarter/jumpstarter/common/grpc.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: e2e
• GitHub Check: pytest-matrix (3.13)
• GitHub Check: pytest-matrix (3.11)
• GitHub Check: pytest-matrix (3.12)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter-utils Dockerfile.utils)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter-devspace .devfile/Containerfile.client)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter-dev .devfile/Containerfile)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter Dockerfile)

🔇 Additional comments (1)

packages/jumpstarter/jumpstarter/common/grpc.py (1)

52-52: Appropriate fix to prevent gRPC keepalives from stopping.

Setting grpc.http2.max_pings_without_data to 0 effectively disables the limit on keepalive pings without data, addressing the issue described in the PR where keepalives would stop after 5 pings. This change ensures that the keepalive mechanism continues to function indefinitely, preventing cloud load balancers from closing connections due to inactivity.

This aligns perfectly with the comment on line 49 about maintaining "a low keepalive time to avoid idle timeouts on cloud load balancers."

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for jumpstarter-docs ready!

Name	Link
🔨 Latest commit	0a9b71c
🔍 Latest deploy log	https://app.netlify.com/sites/jumpstarter-docs/deploys/67dd43ec1d66a300077c3d81
😎 Deploy Preview	https://deploy-preview-368--jumpstarter-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.