Skip to content

ci: report lint, build and test as separate checks - #2

Merged
fuzcap merged 1 commit into
mainfrom
ci/lint-build-test
Oct 8, 2026
Merged

fuzcap merged 1 commit into
mainfrom
ci/lint-build-test

Conversation

@Alexkuva

Copy link
Copy Markdown
Contributor

The default-branch ruleset requires three checks named lint, build and test, as in every Kaiten SDK repository, but CI published a single Lint, Build & Test job. No pull request could satisfy the ruleset, so none could merge: #1 is blocked with every check green.

This splits the job into the three checks the ruleset names, the same split as kaitencloud/cli:

Check Steps (unchanged)
lint golangci-lint v2.12.2, go mod tidy leaves go.mod/go.sum untouched, govulncheck
build go build ./...
test go test -race -shuffle=on -cover ./...

The workflow token is now read-only (permissions: contents: read).

After the merge

A pull_request run reads the workflow from the merge commit, so #1 picks up the three checks on its next run (re-run its checks, or push to it). It still needs its review.

This is step 4 of the licensing pack (kaitencloud/brain, licence/sdk/README.md); the pack itself and the DCO come next, in their own pull request.

Checked

  • actionlint on the workflow.
  • This pull request's own run reports lint, build and test.

🤖 Generated with Claude Code · ✅ Tested and approved by Alex (@Alexkuva), maintainer

The default-branch ruleset requires checks named lint, build and test, as in
every Kaiten SDK repository, but CI published a single "Lint, Build & Test"
job. No pull request could satisfy the ruleset, so none could merge.

The job is split into the three checks the ruleset names, with the same steps
as before: lint runs golangci-lint, the go.mod/go.sum check and govulncheck;
build and test run on their own. The workflow token is read-only.

Signed-off-by: Alexandre Bergere <alexandre.bergere@kaiten.sh>
@fuzcap
fuzcap merged commit 260616f into main Oct 8, 2026
6 checks passed
@fuzcap
fuzcap deleted the ci/lint-build-test branch October 8, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants