Repository navigation
ci: report lint, build and test as separate checks - #2
Merged
Merged
Conversation
The default-branch ruleset requires checks named lint, build and test, as in every Kaiten SDK repository, but CI published a single "Lint, Build & Test" job. No pull request could satisfy the ruleset, so none could merge. The job is split into the three checks the ruleset names, with the same steps as before: lint runs golangci-lint, the go.mod/go.sum check and govulncheck; build and test run on their own. The workflow token is read-only. Signed-off-by: Alexandre Bergere <alexandre.bergere@kaiten.sh>
fuzcap
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
default-branchruleset requires three checks namedlint,buildandtest, as in every Kaiten SDK repository, but CI published a singleLint, Build & Testjob. No pull request could satisfy the ruleset, so none could merge: #1 is blocked with every check green.This splits the job into the three checks the ruleset names, the same split as
kaitencloud/cli:lintgo mod tidyleavesgo.mod/go.sumuntouched, govulncheckbuildgo build ./...testgo test -race -shuffle=on -cover ./...The workflow token is now read-only (
permissions: contents: read).After the merge
A
pull_requestrun reads the workflow from the merge commit, so #1 picks up the three checks on its next run (re-run its checks, or push to it). It still needs its review.This is step 4 of the licensing pack (
kaitencloud/brain,licence/sdk/README.md); the pack itself and the DCO come next, in their own pull request.Checked
actionlinton the workflow.lint,buildandtest.🤖 Generated with Claude Code · ✅ Tested and approved by Alex (@Alexkuva), maintainer