Skip to content

Migrate scheduler config to jobs#14

Merged
s-hiraoku merged 1 commit into
mainfrom
kaizen/issue-13-scheduler-jobs
Jun 22, 2026
Merged

Migrate scheduler config to jobs#14
s-hiraoku merged 1 commit into
mainfrom
kaizen/issue-13-scheduler-jobs

Conversation

@s-hiraoku

@s-hiraoku s-hiraoku commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Move .kaizen/config.yml from fixed scheduler fields to scheduler.jobs.
  • Represent the 01:45 guarded run as maintenance and the 13:45 unguarded run as maintenance-followup.
  • Keep the disabled poll behavior as a disabled issue-watch job.

Verification

  • Repository validation commands from .kaizen/config.yml
  • Parsed the updated config with the current kaizen-loop schema

Closes #13

Summary by CodeRabbit

  • Chores
    • Updated the scheduler configuration to use a new job-based structure.
    • Adjusted maintenance timing to two daily runs with distinct execution parameters.
    • Replaced the prior interval-based watch setup with a clearly defined, currently disabled issue-watch job.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e5a54846-cdc8-4bae-9147-5b3013f244f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The .kaizen/config.yml scheduler section is rewritten to replace the legacy nightly, afternoon, and poll top-level keys with a scheduler.jobs map. Two maintenance jobs are added with a times-based schedule at 01:45 (with lateStartGuard: true) and 13:45 (with lateStartGuard: false), both using run.mode: maintenance. An issue-watch job replaces poll with a 5-minute interval schedule, run.mode: watch, and skipIfRunning: true while remaining disabled.

Changes

Scheduler Config Migration

Layer / File(s) Summary
scheduler.jobs restructure
.kaizen/config.yml
Removes the nightly, afternoon, and poll top-level scheduler keys. Introduces scheduler.jobs with maintenance job entries for 01:45 (lateStartGuard: true) and 13:45 (lateStartGuard: false), both with run.mode: maintenance, and an issue-watch job (5-minute interval, run.mode: watch, skipIfRunning: true, disabled).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • #13 [monitor] Migrate scheduler config to scheduler.jobs — This PR directly implements the migration described in the issue, converting .kaizen/config.yml from the legacy scheduler.nightly/afternoon/poll shape to the scheduler.jobs structure with the recommended maintenance and issue-watch job definitions.

Possibly related PRs

  • kaizen-agents-org/.github#20: Modifies .kaizen/config.yml with scheduler configuration changes covering the same nightly run times and 5-minute interval polling with skipIfRunning.
  • kaizen-agents-org/builder-agent#21: Updates .kaizen/config.yml with a scheduler.poll interval-based setup (5 minutes, skipIfRunning) that this PR supersedes with the issue-watch job.
  • kaizen-agents-org/kaizen-loop#66: Modifies .kaizen/config.yml's scheduler.jobs.maintenance configuration, directly overlapping with this PR's maintenance job definitions and lateStartGuard settings.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: migrating scheduler configuration to the new jobs schema.
Linked Issues check ✅ Passed The PR fully implements issue #13 requirements: migrates to scheduler.jobs schema, consolidates fixed times into single maintenance job with times schedule, preserves disabled issue-watch job, and maintains 01:45/13:45 JST cadence.
Out of Scope Changes check ✅ Passed All changes are directly related to the scheduler configuration migration. Only .kaizen/config.yml was modified with no extraneous alterations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kaizen/issue-13-scheduler-jobs

Comment @coderabbitai help to get the list of available commands.

@s-hiraoku s-hiraoku force-pushed the kaizen/issue-13-scheduler-jobs branch from 6aac1f2 to f31b0eb Compare June 22, 2026 22:12

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.kaizen/config.yml:
- Around line 17-32: The configuration currently defines two separate
maintenance jobs (the maintenance job and the maintenance-followup job), each
with a single daily schedule time, but they should be consolidated into a single
maintenance job with multiple scheduled times to match the migration contract.
Remove the maintenance-followup job definition entirely and update the
maintenance job's schedule to support multiple execution times (01:45 and 13:45)
using a times-based schedule structure instead of the current daily schedule
with a single time field.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3331fa71-7447-4679-96fb-53d57de9be17

📥 Commits

Reviewing files that changed from the base of the PR and between 6aac1f2 and f31b0eb.

📒 Files selected for processing (1)
  • .kaizen/config.yml

Comment thread .kaizen/config.yml
@s-hiraoku

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[monitor] Migrate scheduler config to scheduler.jobs

1 participant