Skip to content

fix(resolver): redact RPC credentials from readiness output - #244

Merged
karagozemin merged 1 commit into
karagozemin:masterfrom
emirykl:drips/issue-233-scf-high-easy-redact-rpc-credentials-from-readin
Aug 31, 2026
Merged

fix(resolver): redact RPC credentials from readiness output#244
karagozemin merged 1 commit into
karagozemin:masterfrom
emirykl:drips/issue-233-scf-high-easy-redact-rpc-credentials-from-readin

Conversation

@emirykl

@emirykl emirykl commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Redact resolver EVM and Soroban readiness URLs to protocol and host, removing user info, path credentials, and query parameters.
  • Sanitize URL-bearing RPC errors and coordinator diagnostics while preserving host and chain/ledger details.
  • Add regression tests covering secret-bearing success and error URLs.

Test evidence:

  • @oversync/resolver Vitest: 4 files, 57 tests passed.
  • @oversync/sdk build passed.
  • @oversync/resolver build passed.
  • @oversync/resolver lint passed.
  • git diff --check passed.
  • Coordinator-wide tests were attempted but remain blocked by unrelated baseline failures (missing supertest/pino dependencies and an existing syntax error in coordinator/src/persistence/orders-repo.ts).

Fixes #233

Verification

  • ``node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/resolver test (57 passed)
  • ``node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/sdk build (passed)
  • ``node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/resolver build (passed)
  • ``node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/resolver lint (passed)
  • ``git diff --check (passed)
  • Coordinator test suite attempted; unrelated baseline failures documented in PR body

Diagnostics

Recovered command failures: /bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack pnpm install --frozen-lockfile --ignore-scripts' (1), /bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack pnpm@9.15.9 --version' (127), /bin/zsh -lc 'COREPACK_HOME=/tmp/oversync-corepack corepack prepare pnpm@9.15.9 --activate && COREPACK_HOME=/tmp/oversync-corepack pnpm --version && COREPACK_HOME=/tmp/oversync-corepack pnpm install --frozen-lockfile --ignore-scripts' (1), /bin/zsh -lc 'node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --version && node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs install --frozen-lockfile --ignore-scripts' (1), /bin/zsh -lc 'node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs install --lockfile=false --ignore-scripts' (1), /bin/zsh -lc 'node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/resolver test --run' (1), /bin/zsh -lc 'node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/resolver build' (2), /bin/zsh -lc 'node /tmp/oversync-corepack/v1/pnpm/9.15.9/bin/pnpm.cjs --filter @oversync/coordinator test' (1)

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

@emirykl is attempting to deploy a commit to the karagoz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@emirykl Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin
karagozemin merged commit e7196a7 into karagozemin:master Aug 31, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SCF high][easy] Redact RPC credentials from readiness output

2 participants