Skip to content

Switch CodSpeed benchmarks to instrumented mode#685

Open
MatthewMckee4 wants to merge 4 commits intomainfrom
switch-codspeed-instrumented
Open

Switch CodSpeed benchmarks to instrumented mode#685
MatthewMckee4 wants to merge 4 commits intomainfrom
switch-codspeed-instrumented

Conversation

@MatthewMckee4
Copy link
Copy Markdown
Member

Summary

Switches the CodSpeed benchmark job from walltime to instrumented mode. Walltime was running on ubuntu-latest (with a # should be codspeed-macro note) because we can't use CodSpeed's managed macro runners, and shared GitHub VMs are too noisy for reliable walltime numbers. Instrumented mode counts CPU instructions via valgrind, so results are deterministic on any runner.

The bench target (codspeed-divan-compat) supports both modes — the only build-time switch was -m walltime, which is now dropped. Removed the mode: walltime input from the action and the now-unused codspeed-macro label from actionlint.yaml.

Test Plan

ci

@MatthewMckee4 MatthewMckee4 added the ci Related to internal CI tooling label Apr 15, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2026

Merging this PR will create unknown performance changes

🆕 1 new benchmark
⏩ 1 skipped benchmark1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
🆕 Simulation karva_benchmark N/A 46.1 ms N/A

Comparing switch-codspeed-instrumented (4376e52) with main (faef1bf)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Related to internal CI tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant