Switch CodSpeed benchmarks to instrumented mode#685
Open
MatthewMckee4 wants to merge 4 commits intomainfrom
Open
Switch CodSpeed benchmarks to instrumented mode#685MatthewMckee4 wants to merge 4 commits intomainfrom
MatthewMckee4 wants to merge 4 commits intomainfrom
Conversation
Merging this PR will create unknown performance changes
Performance Changes
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the CodSpeed benchmark job from walltime to instrumented mode. Walltime was running on
ubuntu-latest(with a# should be codspeed-macronote) because we can't use CodSpeed's managed macro runners, and shared GitHub VMs are too noisy for reliable walltime numbers. Instrumented mode counts CPU instructions via valgrind, so results are deterministic on any runner.The bench target (
codspeed-divan-compat) supports both modes — the only build-time switch was-m walltime, which is now dropped. Removed themode: walltimeinput from the action and the now-unusedcodspeed-macrolabel fromactionlint.yaml.Test Plan
ci