Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/actionlint.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@
# Configuration for the actionlint tool, which we run via prek
# to verify the correctness of the syntax in our GitHub Actions workflows.

self-hosted-runner:
# Various runners we use that aren't recognized out-of-the-box by actionlint:
labels:
- codspeed-macro
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ jobs:
- name: Build docs
run: uv run --isolated --only-group docs zensical build

benchmarks-walltime:
name: "walltime benchmarks"
benchmarks-instrumented:
name: "instrumented benchmarks"

runs-on: ubuntu-latest # should be codspeed-macro
runs-on: ubuntu-latest

needs: determine_changes
if: ${{ (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }}
Expand Down Expand Up @@ -283,13 +283,13 @@ jobs:
- name: Build benchmarks
env:
PYO3_PYTHON: ${{ steps.setup-python.outputs.python-path }}
run: cargo codspeed build -m walltime
run: cargo codspeed build

- name: Run benchmarks
uses: CodSpeedHQ/action@972e3437949c89e1357ebd1a2dbc852fcbc57245 # v4.5.1
env:
PYO3_PYTHON: ${{ steps.setup-python.outputs.python-path }}
with:
token: ${{ secrets.CODSPEED_TOKEN }}
run: cargo codspeed run --bench karva_benchmark_walltime
mode: walltime
run: cargo codspeed run --bench karva_benchmark
mode: simulation
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Infrastructure and tooling:
- `karva_python` — the PyO3 `cdylib` that produces the Python wheel and wraps both `karva` and `karva_worker`.
- `karva_macros` — procedural macros.
- `karva_dev` — dev tools such as CLI reference generation.
- `karva_benchmark` — wall-time benchmark that runs `karva test` against a pinned snapshot of `karva-benchmark-1`.
- `karva_benchmark` — benchmark that runs `karva test` against a pinned snapshot of `karva-benchmark-1`.

### Prerequisites

Expand Down
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions crates/karva_benchmark/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,12 @@ karva_logging = { workspace = true }
karva_metadata = { workspace = true }
karva_project = { workspace = true }
karva_runner = { workspace = true }
karva_static = { workspace = true }
ruff_python_ast = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }

[[bench]]
name = "karva_benchmark_walltime"
name = "karva_benchmark"
harness = false

[lints]
Expand Down
4 changes: 2 additions & 2 deletions crates/karva_benchmark/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//! Wall-time benchmark for karva.
//! Benchmark for karva.
//!
//! Clones a fixed snapshot of <https://github.com/karva-dev/karva-benchmark-1>
//! into `target/benchmark_cache/`, installs its dependencies via uv, and runs
Expand Down Expand Up @@ -36,7 +36,7 @@ pub fn setup_project() -> Project {
/// Run karva tests against the prepared project once.
pub fn run_karva(project: &Project) {
let config = karva_runner::ParallelTestConfig {
num_workers: karva_static::max_parallelism().get(),
num_workers: 2,
no_cache: false,
create_ctrlc_handler: false,
last_failed: false,
Expand Down
Loading