Skip to content

Add checkbox to exclude expired entries in HIBP report - #13726

Open
Litschi21 wants to merge 2 commits into
keepassxreboot:developfrom
Litschi21:feature/11472-hibp-exclude-expired-checkbox
Open

Litschi21 wants to merge 2 commits into
keepassxreboot:developfrom
Litschi21:feature/11472-hibp-exclude-expired-checkbox

Conversation

@Litschi21

Copy link
Copy Markdown

Added a checkbox that allows you to exclude expired entries in the HIBP report. Note that using the "also show entries that have been excluded from reports" option currently shows the expired entries. If this is unwanted or if I should make this a setting, please tell me.

Fixes #11472

Screenshots

Option disabled:
image

Option enabled:
image

Testing strategy

I tested them manually by using the option and making sure that it actually hides expired entries as well as running all the tests. All of them pass.

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey added feature: Reports pr: new feature Pull request adds a new feature labels Sep 29, 2026
@droidmonkey droidmonkey added this to the v2.8.1 milestone Sep 29, 2026
@Litschi21

Copy link
Copy Markdown
Author

@droidmonkey You should be able to run the tests and merge everything from this change and the tests should all pass. MacOS failed, because it timed out. I added the translation via the release-tool.py file.

@droidmonkey

Copy link
Copy Markdown
Member

Why are svg images added to this?

@Litschi21

Copy link
Copy Markdown
Author

Leftover from another thing I was working on, you can just delete them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Reports pr: new feature Pull request adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude expired entries from HIBP report - maybe separate checkbox

2 participants