Skip to content

Add checkbox to exclude expired entries in HIBP report #13726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Litschi21 wants to merge 3 commits into
base: develop
Choose a base branch
from
+13 −1
Open

Add checkbox to exclude expired entries in HIBP report #13726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1060566
Add checkbox to exclude expired entries in HIBP report
Litschi21 Sep 29, 2026
55172cf
Add translation
Litschi21 Oct 2, 2026
ae69c0b
Remove unrelated files
droidmonkey Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions share/translations/keepassxc_en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9892,6 +9892,10 @@ This option is deprecated, use --set-key-file instead.</source>
<numerusform></numerusform>
</translation>
</message>
<message>
<source>Hide expired entries</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>ReportsWidgetPasskeys</name>
Expand Down
3 changes: 2 additions & 1 deletion src/gui/reports/ReportsWidgetHibp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ ReportsWidgetHibp::ReportsWidgetHibp(QWidget* parent)
connect(m_ui->hibpTableView, SIGNAL(doubleClicked(QModelIndex)), SLOT(emitEntryActivated(QModelIndex)));
connect(m_ui->hibpTableView, SIGNAL(customContextMenuRequested(QPoint)), SLOT(customMenuRequested(QPoint)));
connect(m_ui->showKnownBadCheckBox, SIGNAL(stateChanged(int)), this, SLOT(makeHibpTable()));
connect(m_ui->hideExpired, SIGNAL(stateChanged(int)), this, SLOT(makeHibpTable()));
#ifdef KPXC_FEATURE_NETWORK
connect(&m_downloader, SIGNAL(hibpResult(QString, int)), SLOT(addHibpResult(QString, int)));
connect(&m_downloader, SIGNAL(fetchFailed(QString)), SLOT(fetchFailed(QString)));
Expand Down Expand Up @@ -153,7 +154,7 @@ void ReportsWidgetHibp::makeHibpTable()
auto title = entry->title();

// Hide entry if excluded unless explicitly requested
if (entry->excludeFromReports()) {
if (entry->excludeFromReports() || (m_ui->hideExpired->isChecked() && entry->isExpired())) {
anyExcluded = true;
if (!showExcluded) {
continue;
Expand Down
7 changes: 7 additions & 0 deletions src/gui/reports/ReportsWidgetHibp.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,13 @@
<string>Also show entries that have been excluded from reports</string>
</property>
</widget>
</item>
<item>
<widget class="QCheckBox" name="hideExpired">
<property name="text">
<string>Hide expired entries</string>
</property>
</widget>
</item>
</layout>
</widget>
Expand Down
Loading