Improve cross-compiling ARM64 on Windows - #13727
Open
droidmonkey wants to merge 3 commits into
Open
droidmonkey wants to merge 3 commits into
droidmonkey wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Qt6_PREFIX is used before initialization and remains unset in important configurations.
Review effort: Balanced
Findings: 1
What changed in this PR
Improves Windows ARM64 cross-compilation and Qt deployment behavior.
Changes:
- Uses host Qt and Visual Studio tools for cross-compilation.
- Corrects Qt6 translation deployment and removes legacy
qt.conf. - Updates the default signing timestamp service.
| File | Description |
|---|---|
CMakeLists.txt |
Revises Qt deployment-tool discovery. |
release-tool.py |
Configures Visual Studio host architecture and timestamping. |
share/CMakeLists.txt |
Removes legacy qt.conf installation. |
share/translations/CMakeLists.txt |
Corrects the Qt6 translation path. |
share/windows/qt.conf |
Deletes obsolete Windows Qt configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
* Fix using the specified QT_HOST_PATH for executables * Fix setting the Visual Studio environment for cross-compiling
droidmonkey
force-pushed
the
fix/build-fixes
branch
from
September 30, 2026 04:22
d620ea0 to
9caa7fd
Compare
Comment on lines
509
to
+510
| if(_deployqt_exe_name) | ||
| # Check if the Qt host path is specified or if we need to determine it based on the build configuration |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13727 +/- ##
===========================================
- Coverage 63.33% 63.27% -0.06%
===========================================
Files 388 388
Lines 41288 41288
===========================================
- Hits 26147 26123 -24
- Misses 15141 15165 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phoerious
approved these changes
Sep 30, 2026
phoerious
left a comment
phoerious
left a comment
Member
There was a problem hiding this comment.
Check the Copilot complaint. Rest looks good to me.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing strategy
Tested building new 2.8.0 snapshots with success
Type of change