Hoist function-body use statements to module level#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
usestatements that were declared inside function bodies up to module level, keeping imports in one place per file.Ten imports were hoisted across six files; the
#[cfg(unix)]guard onOpenOptionsExtis preserved so non-unix builds are unaffected. Test-module imports (use super::*;and friends inside#[cfg(test)]) are left as-is, since that is the standard Rust idiom.Files touched:
models/deployments.rs—std::str::FromStrcommands/init.rs—std::os::unix::fs::OpenOptionsExtruntime/containerd/image.rs—base64::Engineruntime/firecracker/lifecycle.rs—GuestMount,volume_image,nixsignal/pidruntime/cloud_hypervisor/lifecycle.rs—tokio::io::AsyncReadExt,futures::stream,HealthCheckStatusapi/action/login.rs—token(into the test module)cargo checkpasses with no errors or unused-import warnings.