feat(telemetry): export per-deployment metrics and logs over OTLP#187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two OpenTelemetry export signals alongside the existing traces support (#186), each opt-in and independently toggled under
[server.telemetry].What's new
ring.deployment.{cpu.percent,memory.used_bytes,memory.limit_bytes,network.rx_bytes,network.tx_bytes,disk.read_bytes,disk.write_bytes,pids,instances,restarts}, labelled{deployment, namespace, runtime}. Read from the same background stats cache the Prometheus/metricsendpoint uses, so no extra runtime round-trip is added.OTEL_*env vars override the TOML per signal (OTEL_EXPORTER_OTLP_{METRICS,LOGS}_ENDPOINT,OTEL_SERVICE_NAME).Incidental fix
The
telemetry: OTLP ... enabledstartup lines were emitted before the tracing subscriber was initialised, so they were silently dropped. They are now buffered and replayed after.init(), which also fixes the traces enable line.Validation
t16/t17: operational e2e (boot + graceful degradation against a closed collector port).t18: real ingestion e2e — runs an OpenTelemetry Collector in Docker, deploys a container, and asserts thering.deployment.*metrics and Ring log records actually reach the collector. Stable across 3 runs; skips cleanly when Docker is absent.Note
Prometheus scrape export already exists (the
/metricsendpoint), so this PR intentionally covers only the OTLP push path for metrics and logs.