refactor(web): begin implementation of SearchCluster for merging paths reaching the same intermediate tokenization state 🚂 #14949
+744
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
6ddd57f to
9068e40
Compare
jahorton
force-pushed
the
refactor/web/simple-search-space-reuse
branch
from
1eaf922 to
ddf9a58
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
9068e40 to
b8457ec
Compare
keymanapp-test-bot
bot
changed the title
jahorton
changed the base branch from
refactor/web/simple-search-space-reuse
to
refactor/web/multi-space-correction-search
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
228d93a to
f3fc256
Compare
jahorton
changed the base branch from
refactor/web/multi-space-correction-search
to
refactor/web/search-batcher
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
f3fc256 to
a6e14c5
Compare
jahorton
changed the base branch from
refactor/web/search-batcher
to
change/web/start-search-path
jahorton
changed the base branch from
change/web/start-search-path
to
refactor/web/multi-space-correction-search
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
a6e14c5 to
a03bc15
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
02b9293 to
96a4b99
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
a03bc15 to
3f199ce
Compare
jahorton
changed the title
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
2 times, most recently
from
3fe8645 to
de3d86c
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
3f199ce to
0e70658
Compare
jahorton
changed the base branch from
refactor/web/multi-space-correction-search
to
refactor/web/search-path-merging
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
0e70658 to
72798ba
Compare
jahorton
commented
Nov 4, 2025
| }); | ||
|
|
||
| it('handles case that triggers a token merge: can+\'+t', () => { | ||
| it.skip('handles case that triggers a token merge: can+\'+t', () => { |
Contributor
Author
There was a problem hiding this comment.
TODO: double-check - is this still valid? I thought I reworked things to be supported at this point; this change may be a holdover from a previous implementation strategy.
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
076bfdc to
bc51029
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
ca906dd to
316abe3
Compare
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
bc51029 to
413fdcf
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
316abe3 to
ef700d0
Compare
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
413fdcf to
e9b8e2d
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
ef700d0 to
567ba68
Compare
jahorton
force-pushed
the
refactor/web/search-path-merging
branch
from
e9b8e2d to
9b947b7
Compare
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
567ba68 to
0286e3c
Compare
jahorton
changed the base branch from
refactor/web/search-path-merging
to
refactor/web/simplify-input-segments
This is to prepare for corrections from alternate tokenizations that could result from fat-fingering whitespace keys or similar effects. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/complex-search-space-reuse
branch
from
18c246a to
d98603f
Compare
jahorton
commented
Nov 13, 2025
Comment on lines
+166
to
+169
| public stopTrackingResults() { | ||
| delete this.completedPaths; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Suggested change
| public stopTrackingResults() { | |
| delete this.completedPaths; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new implementation of the
SearchSpaceinterface -SearchCluster. TheSearchClustertype is designed to represent cases where two or moreSearchPathinstances represent the same total range of user input, as described in #15104's description as them "converging". In such cases, extending the search space by new input proceeds in exactly the same manner, regardless of which parent space is the original source. It's notably more efficient to cluster the paths together.Also note that
SearchClusterdirectly reflects aTokenizationSubset(as described in #15140) - any of the paths leading to the cluster will correct to words of the same length, representing the same keystroke range from the user. Use of this type thus allows us to build a singleContextTokenizationinstance to represent the convergence of these paths - both for correction-search operations and for preservation of state after application of a suggestion arising from it.Build-bot: skip build:web
Test-bot: skip