-
-
Notifications
You must be signed in to change notification settings - Fork 130
change(web): track right-hand split index for input source of tokenized transforms 🚂 #15104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jahorton
wants to merge
4
commits into
refactor/web/search-path-splitting
Choose a base branch
from
change/web/track-righthand-split-index
base: refactor/web/search-path-splitting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
change(web): track right-hand split index for input source of tokenized transforms 🚂 #15104
jahorton
wants to merge
4
commits into
refactor/web/search-path-splitting
from
change/web/track-righthand-split-index
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
6daa809 to
461fa4d
Compare
e65ad7c to
5f1ce79
Compare
2fc98eb to
e6cbc29
Compare
…ed transforms Build-bot: skip build:web Test-bot: skip
220bf34 to
b51dbc3
Compare
…ck-righthand-split-index
…ck-righthand-split-index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much examination, I believe that in order to identify use of subsets of user input that converge to a common prefix for future extensions, we need to track and reference the right-hand index used to split input transforms when such splits occur. This will also assist with identification of cases where a previously-split input is to be remerged; the earlier component's "split" index (.end) will match the later component's .start index for such cases.
To clarify the requirements for considering subsets of user input to converge:
InputSegmentproperties for each input must cover exactly the same range..transitionIdentries..transitionIdentry, the.startand.endvalues must match precisely.To restate this more plainly:
Build-bot: skip build:web
Test-bot: skip