Adds ConcreteTexture.ValidateGetDataSurfaceFormat methods#2636
Open
squarebananas wants to merge 2 commits into
Open
Adds ConcreteTexture.ValidateGetDataSurfaceFormat methods#2636squarebananas wants to merge 2 commits into
squarebananas wants to merge 2 commits into
Conversation
This was referenced Jun 10, 2026
Contributor
|
@squarebananas , would you please rebase this, to see if it builds? |
squarebananas
force-pushed
the
TextureGetDataFormat
branch
from
July 24, 2026 14:46
cd6eae3 to
5f55bb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ConcreteTexture.ValidateGetDataSurfaceFormat methods for GLES & BlazorGL.
As
GetTexImageandGetCompressedTexImageare unavailable on GLES and WebGL, for these platforms it is necessary to useFramebufferTexturealong withReadPixelsfor theTexture.GetDataimplementations. However this approach cannot be used with allSurfaceFormattypes.Currently there is a comment related to this as follows:
// TODO: check for non renderable formats (formats that can't be attached to FBO)By adding these methods, this will allow subsequent PRs to implement throwing an exception if an unsupported
SurfaceFormatis used withTexture.GetData.This PR follows on from the #2635 PR. Although not directly dependent itself, some of the subsequent PRs will need both these PRs for their implementations.