fix: add missing return err in checkIfIpIsLive to prevent nil pointer panic

[123456wda]

@

Summary

Fix a nil pointer dereference panic in checkIfIpIsLive when DNS resolution fails.

Problem

In pkg/ibm/ibmz_helpers.go, the function checkIfIpIsLive has a missing return after a failed net.ResolveTCPAddr call. When DNS resolution fails, the error is logged but execution continues to call server.Network() and server.String() on the nil *net.TCPAddr, causing a panic.

Fix

Add a return err after the log.Error call, matching the error-handling pattern used elsewhere in the same function (lines 89 and 93).

Test

Added checkIfIpIsLive test that verifies DNS resolution failure returns an error rather than panicking. The test uses "a b c" (hostname with spaces) which causes net.ResolveTCPAddr to fail deterministically without any network call (0ms).

Verification

go vet ./pkg/ibm/          # passes
go test ./pkg/ibm/ -v      # new test passes

Fixes #985

🤖 Generated with Claude Code
@

[qodo-app-for-konflux-ci]

PR Summary by Qodo

Fix nil pointer panic on DNS resolution failure in checkIfIpIsLive

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes

AI Description

• Return early when ResolveTCPAddr fails to avoid nil pointer dereference.
• Add a unit test ensuring DNS resolution errors are returned (no panic).
• Use an invalid hostname to make the failure deterministic and local-only.

Diagram

graph TD
  A[Caller] --> B["checkIfIpIsLive"] --> C["net.ResolveTCPAddr"] --> D{"Resolved?"}
  D -->|"no"| G["return err"]
  D -->|"yes"| E["net.DialTimeout"] --> F["nil / err"]

Loading

High-Level Assessment

The early-return fix is the correct and minimal change: it aligns with existing error-handling branches in the same function and prevents dereferencing a nil *net.TCPAddr. The added regression test appropriately targets the failure mode without relying on external network conditions.

Files changed (2) +15 / -0

Bug fix (1) +1 / -0

ibmz_helpers.goReturn error after failed TCP address resolution +1/-0

Return error after failed TCP address resolution

• Adds a missing 'return err' after 'net.ResolveTCPAddr' fails so the function does not continue with a nil '*net.TCPAddr'. This prevents a nil pointer dereference when DNS/host resolution fails.

pkg/ibm/ibmz_helpers.go

Tests (1) +14 / -0

ibmz_helpers_test.goAdd regression test for DNS resolution failure in checkIfIpIsLive +14/-0

Add regression test for DNS resolution failure in checkIfIpIsLive

• Introduces a test that passes an invalid hostname containing spaces to force 'net.ResolveTCPAddr' to fail immediately. Asserts the function returns an error (and does not panic).

pkg/ibm/ibmz_helpers_test.go

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 1:53 PM UTC · Completed 2:04 PM UTC
Commit: 37b10e4 · View workflow run →

[qodo-app-for-konflux-ci]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

[fullsend-ai-review]

Looks good to me

---

Labels: Bug fix adding missing error return in IBM cloud provider package — minimal scope, low risk