Skip to content

fix: add missing return err in checkIfIpIsLive to prevent nil pointer panic #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
123456wda wants to merge 1 commit into from
Closed

fix: add missing return err in checkIfIpIsLive to prevent nil pointer panic #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/ibm/ibmz_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func checkIfIpIsLive(ctx context.Context, ip string) error {
server, err := net.ResolveTCPAddr("tcp", ip+":22")
if err != nil {
log.Error(err, "failed to resolve ip address")
return err
}
conn, err := net.DialTimeout(server.Network(), server.String(), 5*time.Second)
if err != nil {
Expand Down
14 changes: 14 additions & 0 deletions pkg/ibm/ibmz_helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package ibm

import (
"context"
"fmt"
"regexp"

Expand Down Expand Up @@ -101,4 +102,17 @@ var _ = Describe("IBM s390x Helper Functions", func() {
"System Z Max Tag Length"),
)
})

Describe("The checkIfIpIsLive function", func() {
When("the DNS resolution of the host fails", func() {
It("should return an error instead of panicking", func() {
ctx := context.Background()
// "a b c" contains spaces, which are invalid in DNS names
// — this causes net.ResolveTCPAddr to fail immediately
// (0ms, pure local resolution) without any network call.
err := checkIfIpIsLive(ctx, "a b c")
Expect(err).Should(HaveOccurred())
})
})
})
})
Loading