Skip to content

feat(api): add immutability for TrainingRuntimes types#3082

Closed
Misha6Sharma wants to merge 3 commits intokubeflow:masterfrom
Misha6Sharma:misha-issue-2559
Closed

feat(api): add immutability for TrainingRuntimes types#3082
Misha6Sharma wants to merge 3 commits intokubeflow:masterfrom
Misha6Sharma:misha-issue-2559

Conversation

@Misha6Sharma
Copy link
Copy Markdown

@Misha6Sharma Misha6Sharma commented Jan 11, 2026

What this PR does / why we need it:
This PR implements immutability for TrainingRuntime and ClusterTrainingTime to prevent any modifications after its creation
Used CRD Markers and Webhooks for the same for the .spec and .metadata(labels and annotations) fields

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2599

Checklist:

  • Docs included if any changes are user facing

@github-actions
Copy link
Copy Markdown

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Misha6Sharma and others added 2 commits January 11, 2026 18:58
Signed-off-by: Misha Sharma <misha6sharma@gmail.com>
Signed-off-by: Misha Sharma <misha6sharma@gmail.com>
@andreyvelich
Copy link
Copy Markdown
Member

Thanks @Misha6Sharma, we are going to discuss this as part of this KEP: #3428
/close
cc @robert-bell

@google-oss-prow google-oss-prow Bot closed this Apr 15, 2026
@google-oss-prow
Copy link
Copy Markdown

@andreyvelich: Closed this PR.

Details

In response to this:

Thanks @Misha6Sharma, we are going to discuss this as part of this KEP: #3428
/close
cc @robert-bell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement validations to prevent changing TrainingRuntime

2 participants