feat(api): add immutability for TrainingRuntimes types#3082
feat(api): add immutability for TrainingRuntimes types#3082Misha6Sharma wants to merge 3 commits intokubeflow:masterfrom
Conversation
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Misha Sharma <misha6sharma@gmail.com>
Signed-off-by: Misha Sharma <misha6sharma@gmail.com>
5f8ae3f to
17b858f
Compare
|
Thanks @Misha6Sharma, we are going to discuss this as part of this KEP: #3428 |
|
@andreyvelich: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR implements immutability for TrainingRuntime and ClusterTrainingTime to prevent any modifications after its creation
Used CRD Markers and Webhooks for the same for the .spec and .metadata(labels and annotations) fields
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2599
Checklist: