feat(api): add immutability for TrainingRuntimes types

charts/kubeflow-trainer/crds/trainer.kubeflow.org_clustertrainingruntimes.yaml

@@ -12,15 +12,11 @@ spec:
     listKind: ClusterTrainingRuntimeList
     plural: clustertrainingruntimes
     singular: clustertrainingruntime
-  scope: Cluster
+  scope: Namespaced
   versions:
   - name: v1alpha1
     schema:
       openAPIV3Schema:
-        description: |-
-          ClusterTrainingRuntime represents a training runtime which can be referenced as part of
-          `runtimeRef` API in TrainJob. This resource is a cluster-scoped and can be referenced
-          by TrainJob that created in *any* namespace.
         properties:
           apiVersion:
             description: |-
@@ -10446,6 +10442,12 @@ spec:
                         == ''InOrder'' && self.replicatedJobs.exists(x, has(x.dependsOn)))'
                 type: object
             type: object
+            x-kubernetes-validations:
+            - message: Value is immutable
+              rule: self == oldSelf
         type: object
+        x-kubernetes-validations:
+        - message: Value is immutable
+          rule: self == oldSelf
     served: true
     storage: true

charts/kubeflow-trainer/crds/trainer.kubeflow.org_trainingruntimes.yaml

@@ -17,10 +17,6 @@ spec:
   - name: v1alpha1
     schema:
       openAPIV3Schema:
-        description: |-
-          TrainingRuntime represents a training runtime which can be referenced as part of
-          `runtimeRef` API in TrainJob. This resource is a namespaced-scoped and can be referenced
-          by TrainJob that created in the *same* namespace as the TrainingRuntime.
         properties:
           apiVersion:
             description: |-
@@ -10446,6 +10442,12 @@ spec:
                         == ''InOrder'' && self.replicatedJobs.exists(x, has(x.dependsOn)))'
                 type: object
             type: object
+            x-kubernetes-validations:
+            - message: Value is immutable
+              rule: self == oldSelf
         type: object
+        x-kubernetes-validations:
+        - message: Value is immutable
+          rule: self == oldSelf
     served: true
     storage: true

manifests/base/crds/trainer.kubeflow.org_clustertrainingruntimes.yaml

@@ -12,15 +12,11 @@ spec:
     listKind: ClusterTrainingRuntimeList
     plural: clustertrainingruntimes
     singular: clustertrainingruntime
-  scope: Cluster
+  scope: Namespaced
   versions:
   - name: v1alpha1
     schema:
       openAPIV3Schema:
-        description: |-
-          ClusterTrainingRuntime represents a training runtime which can be referenced as part of
-          `runtimeRef` API in TrainJob. This resource is a cluster-scoped and can be referenced
-          by TrainJob that created in *any* namespace.
         properties:
           apiVersion:
             description: |-
@@ -10446,6 +10442,12 @@ spec:
                         == ''InOrder'' && self.replicatedJobs.exists(x, has(x.dependsOn)))'
                 type: object
             type: object
+            x-kubernetes-validations:
+            - message: Value is immutable
+              rule: self == oldSelf
         type: object
+        x-kubernetes-validations:
+        - message: Value is immutable
+          rule: self == oldSelf
     served: true
     storage: true

manifests/base/crds/trainer.kubeflow.org_trainingruntimes.yaml

@@ -17,10 +17,6 @@ spec:
   - name: v1alpha1
     schema:
       openAPIV3Schema:
-        description: |-
-          TrainingRuntime represents a training runtime which can be referenced as part of
-          `runtimeRef` API in TrainJob. This resource is a namespaced-scoped and can be referenced
-          by TrainJob that created in the *same* namespace as the TrainingRuntime.
         properties:
           apiVersion:
             description: |-
@@ -10446,6 +10442,12 @@ spec:
                         == ''InOrder'' && self.replicatedJobs.exists(x, has(x.dependsOn)))'
                 type: object
             type: object
+            x-kubernetes-validations:
+            - message: Value is immutable
+              rule: self == oldSelf
         type: object
+        x-kubernetes-validations:
+        - message: Value is immutable
+          rule: self == oldSelf
     served: true
     storage: true

pkg/apis/trainer/v1alpha1/trainingruntime_types.go

@@ -42,6 +42,9 @@ const (
 // ClusterTrainingRuntime represents a training runtime which can be referenced as part of
 // `runtimeRef` API in TrainJob. This resource is a cluster-scoped and can be referenced
 // by TrainJob that created in *any* namespace.
+
+// +kubebuilder:object:root=true
+// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="Value is immutable"
 type ClusterTrainingRuntime struct {
 	metav1.TypeMeta `json:",inline"`
 
@@ -78,6 +81,9 @@ type ClusterTrainingRuntimeList struct {
 // TrainingRuntime represents a training runtime which can be referenced as part of
 // `runtimeRef` API in TrainJob. This resource is a namespaced-scoped and can be referenced
 // by TrainJob that created in the *same* namespace as the TrainingRuntime.
+
+// +kubebuilder:object:root=true
+// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="Value is immutable"
 type TrainingRuntime struct {
 	metav1.TypeMeta `json:",inline"`
 
@@ -107,6 +113,9 @@ type TrainingRuntimeList struct {
 
 // TrainingRuntimeSpec represents a specification of the desired training runtime.
 // +kubebuilder:validation:MinProperties=1
+
+// +kubebuilder:object:root=true
+// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="Value is immutable"
 type TrainingRuntimeSpec struct {
 	// mlPolicy provides the ML-specific parameters for the model training.
 	// +optional