Update lifecycle release selector for s390x by aditi-sharma-1 · Pull Request #2232 · kubevirt/cluster-network-addons-operator

aditi-sharma-1 · 2025-04-09T12:20:17Z

What this PR does / why we need it:

Full support for the s390x architecture is available starting from CNAO v0.98.2.

This pull request updates the lifecycle CI pipeline and end-to-end test configurations to use v0.98.2 as the starting version for s390x, so that tests can run successfully. These changes help improve compatibility for the s390x architecture.

Release note:

NONE

Previous CNAO versions did not fully support the s390x architecture. Full support has been added starting from v0.98.2. This pull request sets v0.98.2 as the starting version in the lifecycle CI pipeline and the end-to-end test configurations for s390x, ensuring that tests run successfully. These changes improve compatibility for this architecture. Signed-off-by: Aditi Sharma <Aditi.Sharma@ibm.com>

kubevirt-bot · 2025-04-09T12:20:26Z

Hi @aditi-sharma-1. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot · 2025-04-09T12:20:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sonarqubecloud · 2025-04-09T12:21:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

oshoval · 2025-04-09T14:43:38Z

    else
        # Don't run all upgrade tests in regular PRs, stick to those released under HCO
-        export RELEASES_SELECTOR="{0.89.3,0.91.1,0.93.0,0.95.0,99.0.0}"
+        case "$(go env GOARCH)" in


Thanks

instead the change please consider exporting the RELEASES_SELECTOR you want in the s390x lane
i do understand that you will need to update it from time to time, but it can be nicer
wdyt ?

alternative is to auto detect if a release has s390x and skip it if not, and then no need additional changes anymore
It will be best if we can find something minimal that does the job please

cc @RamLavi wdyt?

Good suggestion!

I think we can approach it like this:

Add version 0.98.2 to the list in check-patch.e2e-lifecycle-k8s.sh.

if we don't want to do that then we can skip lifecycle for s390x as s390x supported version 0.98.2 is not release under HCO yet

if we are okay with 1 then
For the s390x Prow lane, we can use RELEASES_DESELECTOR env instead of RELEASES_SELECTOR:

cluster-network-addons-operator/test/releases/releases.go

Line 62 in ec5c996

if releasesDeselectorRaw, found := os.LookupEnv("RELEASES_DESELECTOR"); found {

However, one issue I noticed is that 0.98.2 is not currently part of the populated release list. not sure why ???
You can confirm that from the output shown here: https://sharepad.io/p/5L7nfm9

It seems that the version isn't added in the releases initialization:

cluster-network-addons-operator/test/releases/releases.go

Line 46 in ec5c996

Expect(validateReleasesSelector(releases, releasesSelectorRaw)).NotTo(HaveOccurred())

So before anything else, we’ll need to ensure 0.98.2 is included in the releases definition.

Thank you for looking on it deeply

0.98.2 is just a release on main, so HCO can consume it, since it doesnt belong to a stable branch we should not add it to RELEASES_SELECTOR

Please just set RELEASES_SELECTOR as you wish in the job, but make sure please that someone maintains it

Possible idea for the future - to think on a way that auto select the 3 latest stable branches that are formal, or at least to have one place where we add it manually in the beginning and from there, helper scripts are populating it to the required place, i.e 390x lane

just setting export RELEASES_SELECTOR=0.98.2 is not working, it is failing at below check, as explained earlier

cluster-network-addons-operator/test/releases/releases.go

Line 46 in ec5c996

Expect(validateReleasesSelector(releases, releasesSelectorRaw)).NotTo(HaveOccurred())

Setting RELEASES_SELECTOR alone won't work until we add 0.98.2 to the populated releases list.

we can't add it
we add only latest patch on stables and this isn't stable

can you please try to think about other way / debug it deeper ?

@RamLavi wdyt ?

I don't think we should use 0.98.2, as @oshoval said.
The first release that will have a stable branch AND support the new arch - IIUC is the next one (0.99.0) - which is currently pending merge (once quay outage is over it sould be merged quickly).
I suggest to use that version instead

0.99 is out (well on main still)
once there is a stable branch
#2284
and then we can try according suggested in this thread ?
(strive to keep it as simple as possible please, and as low maintenance we need)

okay, noted.

RamLavi · 2025-06-22T08:26:20Z

Hey ashokpariya0 what's the status of this PR?

ashokpariya0 · 2025-06-22T11:09:36Z

Hey ashokpariya0 what's the status of this PR?

We haven’t tried with version 0.99.0 yet — we’ll give it a try update.
@aditi-sharma-1 can we please try with version 0.99.0 as discussed above? Let’s test it out and update accordingly.

kubevirt-bot · 2025-09-20T12:03:56Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

aditi-sharma-1 · 2025-10-07T09:29:49Z

/remove-lifecycle stale

aditi-sharma-1 · 2025-10-07T09:33:01Z

Hi @ashokpariya0,
Sure, will test once with 0.99.0 version and update here accordingly. Thank you.

Signed-off-by: Aditi Sharma <167422409+aditi-sharma-1@users.noreply.github.com>

sonarqubecloud · 2025-10-24T11:20:30Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

aditi-sharma-1 · 2025-10-24T11:22:05Z

Hi @ashokpariya0,
I tested with v0.99.0 locally on the s390x cluster, and it’s passing successfully. Thank you.

kubevirt-bot · 2026-01-22T12:18:23Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

aditi-sharma-1 · 2026-02-09T17:49:53Z

/remove-lifecycle stale

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 9, 2025

kubevirt-bot requested review from oshoval and phoracek April 9, 2025 12:20

kubevirt-bot added the size/S label Apr 9, 2025

oshoval reviewed Apr 9, 2025

View reviewed changes

oshoval mentioned this pull request May 15, 2025

[main] Release v0.99.0 #2284

Merged

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2025

kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 7, 2025

aditi-sharma-1 added 2 commits October 24, 2025 16:46

Update check-patch.e2e-lifecycle-k8s.sh

841180e

Signed-off-by: Aditi Sharma <167422409+aditi-sharma-1@users.noreply.github.com>

Update upgrade_test.go

50ae234

Signed-off-by: Aditi Sharma <167422409+aditi-sharma-1@users.noreply.github.com>

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2026

kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2026

Conversation

aditi-sharma-1 commented Apr 9, 2025

Uh oh!

kubevirt-bot commented Apr 9, 2025

Uh oh!

kubevirt-bot commented Apr 9, 2025

Uh oh!

sonarqubecloud Bot commented Apr 9, 2025

Quality Gate passed

Uh oh!

oshoval Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashokpariya0 Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

oshoval Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashokpariya0 Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

oshoval Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

oshoval May 5, 2025

Choose a reason for hiding this comment

Uh oh!

RamLavi May 13, 2025

Choose a reason for hiding this comment

Uh oh!

oshoval May 15, 2025

Choose a reason for hiding this comment

Uh oh!

ashokpariya0 May 15, 2025

Choose a reason for hiding this comment

Uh oh!

RamLavi commented Jun 22, 2025

Uh oh!

ashokpariya0 commented Jun 22, 2025

Uh oh!

kubevirt-bot commented Sep 20, 2025

Uh oh!

aditi-sharma-1 commented Oct 7, 2025

Uh oh!

aditi-sharma-1 commented Oct 7, 2025

Uh oh!

sonarqubecloud Bot commented Oct 24, 2025

Quality Gate passed

Uh oh!

aditi-sharma-1 commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Jan 22, 2026

Uh oh!

aditi-sharma-1 commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oshoval Apr 9, 2025 •

edited

Loading

oshoval Apr 20, 2025 •

edited

Loading

aditi-sharma-1 commented Oct 24, 2025 •

edited

Loading