Skip to content

[main] Release v0.99.0#2284

Merged
kubevirt-bot merged 1 commit intomainfrom
rel-pr-0.99.0
May 15, 2025
Merged

[main] Release v0.99.0#2284
kubevirt-bot merged 1 commit intomainfrom
rel-pr-0.99.0

Conversation

@kubevirt-bot
Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Release v0.99.0

NONE

Signed-off-by: GitHub <noreply@github.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 15, 2025
@kubevirt-bot kubevirt-bot requested review from oshoval and qinqon May 15, 2025 08:50
@RamLavi
Copy link
Copy Markdown
Collaborator

RamLavi commented May 15, 2025

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@kubevirt-bot
Copy link
Copy Markdown
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@oshoval
Copy link
Copy Markdown
Collaborator

oshoval commented May 15, 2025

is this release should be on main ?
or on stable branch ?

@oshoval
Copy link
Copy Markdown
Collaborator

oshoval commented May 15, 2025

/hold

please remove the hold once you see the question

forgot the order of the operations, maybe we need a gist :)

also important because it affects #2232

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@RamLavi
Copy link
Copy Markdown
Collaborator

RamLavi commented May 15, 2025

is this release should be on main ?
or on stable branch ?

It should be the tip from which the branch is branched.

So it touches both main and the (soon to be opened) stable branch.

Note that the "create stable branch" gitAction has a field Create CNAO release branch from tag - it will be the tag of this release.

@RamLavi
Copy link
Copy Markdown
Collaborator

RamLavi commented May 15, 2025

is this release should be on main ?
or on stable branch ?

It should be the tip from which the branch is branched.

So it touches both main and the (soon to be opened) stable branch.

Note that the "create stable branch" gitAction has a field Create CNAO release branch from tag - it will be the tag of this release.

double checked with @EdDev, we can proceed.
/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@kubevirt-bot kubevirt-bot merged commit df98f41 into main May 15, 2025
17 checks passed
@RamLavi RamLavi deleted the rel-pr-0.99.0 branch August 20, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants