Skip to content

test(opencode): prove pinned v2 contract - #1670

Merged
kunickiaj merged 1 commit into
mainfrom
09-09-test_opencode_prove_pinned_v2_contract
Sep 9, 2026
Merged

test(opencode): prove pinned v2 contract#1670
kunickiaj merged 1 commit into
mainfrom
09-09-test_opencode_prove_pinned_v2_contract

Conversation

@kunickiaj

@kunickiaj kunickiaj commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Description

Runs the packaged V2 contract fixture through an authenticated pinned-host server and deterministic local provider. The smoke proves real context, primary model-request, HTTP request/response, accepted retry, activation, and cleanup behavior; CI and versioning documentation record the verified contract and the automatic-recall correlation gate.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes
  • Manually verified changes work as expected — packed V1 artifact and pinned V2 host smoke tests pass

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

@kunickiaj
kunickiaj marked this pull request as ready for review September 9, 2026 12:25

kunickiaj commented Sep 9, 2026

Copy link
Copy Markdown
Owner Author

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T22:30:16.805957Z c2e763d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da001c08a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/package.json
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from da001c0 to 1954288 Compare September 9, 2026 12:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1954288973

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs Outdated
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 1954288 to b666fc1 Compare September 9, 2026 15:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b666fc1da6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs
Comment thread docs/opencode-v2-contract.md
@kunickiaj
kunickiaj changed the base branch from 09-08-fix_opencode_align_v1_runtime_contracts to graphite-base/1670 September 9, 2026 15:45
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from b666fc1 to 2d65636 Compare September 9, 2026 15:51
@graphite-app
graphite-app Bot changed the base branch from graphite-base/1670 to main September 9, 2026 15:52
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 2d65636 to 8fbfb80 Compare September 9, 2026 15:52

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8fbfb80eba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/src/opencode-v2-contract-fixture.ts Outdated
Comment thread packages/opencode-plugin/src/opencode-v2-contract-fixture.ts
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs Outdated
@kunickiaj
kunickiaj changed the base branch from main to graphite-base/1670 September 9, 2026 16:04
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 8fbfb80 to 0665ba7 Compare September 9, 2026 16:04
@kunickiaj
kunickiaj changed the base branch from graphite-base/1670 to 09-09-test_opencode_define_v2_contract_fixture September 9, 2026 16:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0665ba72e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0665ba72e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs Outdated
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs Outdated
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_define_v2_contract_fixture branch from 066e8d9 to 77b5a94 Compare September 9, 2026 18:10
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 0665ba7 to 12eda69 Compare September 9, 2026 18:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12eda6989c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_define_v2_contract_fixture branch from 77b5a94 to d020d2c Compare September 9, 2026 20:44
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 12eda69 to 9146356 Compare September 9, 2026 20:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 914635667c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs Outdated
Comment thread packages/opencode-plugin/scripts/packed-v2-host-smoke.mjs Outdated
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 9146356 to 053c12e Compare September 9, 2026 21:34

kunickiaj commented Sep 9, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Sep 9, 10:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 9, 10:26 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 9, 10:31 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj
kunickiaj changed the base branch from 09-09-test_opencode_define_v2_contract_fixture to graphite-base/1670 September 9, 2026 22:18
@kunickiaj
kunickiaj changed the base branch from graphite-base/1670 to main September 9, 2026 22:24
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_prove_pinned_v2_contract branch from 053c12e to c2e763d Compare September 9, 2026 22:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2e763d7cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cwd: options.cwd ?? packageRoot,
encoding: "utf8",
env: options.env ?? process.env,
timeout: options.timeoutMs ?? 300_000,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enforce the timeout for synchronous host commands

If a standalone opencode2 command hangs and traps or ignores SIGTERM, this spawnSync timeout never returns: Node documents that after sending the configured kill signal, the synchronous call waits until the child exits. The forced-kill fallback added to runAsync and stopHost is fresh evidence that this synchronous helper remains uncovered, so the Packaged Plugin Smoke invocation in .github/workflows/ci.yml:171-175 can occupy the runner until the workflow-level limit; run these host commands asynchronously with the same SIGKILL fallback or wrap them in an independently enforced process deadline. Node child-process documentation

Useful? React with 👍 / 👎.

@kunickiaj
kunickiaj merged commit ac064d7 into main Sep 9, 2026
15 checks passed
@kunickiaj
kunickiaj deleted the 09-09-test_opencode_prove_pinned_v2_contract branch September 9, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant