Skip to content

test(opencode): define v2 contract fixture - #1672

Merged
kunickiaj merged 1 commit into
mainfrom
09-09-test_opencode_define_v2_contract_fixture
Sep 9, 2026
Merged

test(opencode): define v2 contract fixture#1672
kunickiaj merged 1 commit into
mainfrom
09-09-test_opencode_define_v2_contract_fixture

Conversation

@kunickiaj

@kunickiaj kunickiaj commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Description

Adds the typed OpenCode 2 fixture and focused tests for lifecycle, events, storage, request hooks, retry decisions, tool outcomes, tool naming, and deterministic cleanup. The fixture is included in the packed plugin so the next PR can execute it against the pinned host.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes — 26 package tests pass
  • Manually verified changes work as expected

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

kunickiaj commented Sep 9, 2026

Copy link
Copy Markdown
Owner Author

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-09T22:22:32.532637Z c3fff5c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kunickiaj kunickiaj changed the title test(opencode): prove pinned v2 contract test(opencode): define v2 contract fixture Sep 9, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 066e8d9bf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/v2-contract-fixture/package.json
Comment thread packages/opencode-plugin/src/opencode-v2-contract-fixture.test.ts
Comment thread packages/opencode-plugin/src/opencode-v2-contract-fixture.test.ts
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_define_v2_contract_fixture branch from 066e8d9 to 77b5a94 Compare September 9, 2026 18:10

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77b5a942de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/opencode-plugin/src/opencode-v2-contract-fixture.ts Outdated
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_define_v2_contract_fixture branch from 77b5a94 to d020d2c Compare September 9, 2026 20:44

kunickiaj commented Sep 9, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Sep 9, 10:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 9, 10:19 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 9, 10:24 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj
kunickiaj changed the base branch from 09-09-chore_opencode_pin_v2_contract_toolchain to graphite-base/1672 September 9, 2026 22:17
@kunickiaj
kunickiaj changed the base branch from graphite-base/1672 to main September 9, 2026 22:17
@kunickiaj
kunickiaj force-pushed the 09-09-test_opencode_define_v2_contract_fixture branch from d020d2c to c3fff5c Compare September 9, 2026 22:18
@kunickiaj
kunickiaj merged commit cbb1b2d into main Sep 9, 2026
15 checks passed
@kunickiaj
kunickiaj deleted the 09-09-test_opencode_define_v2_contract_fixture branch September 9, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant