[Bugfix][TE] Fix Ascend wildcard location probe fallback to host memory - #4056
Open
gygdh-001 wants to merge 1 commit into
Open
[Bugfix][TE] Fix Ascend wildcard location probe fallback to host memory#4056gygdh-001 wants to merge 1 commit into
gygdh-001 wants to merge 1 commit into
Conversation
ResolveAscendMemType() treated aclrtPointerGetAttributes() failure as a hard
error (CHECK_ACL returned -1), so registering host memory with the wildcard
location ("*") failed on Ascend. CUDA already falls back when the wildcard
probe cannot identify the memory; align Ascend by treating probe failure as
host memory (adxl::MEM_HOST).
gygdh-001
requested review from
alogfans and
ascend-direct-dev
as code owners
September 11, 2026 12:30
31 tasks
Collaborator
|
Thanks for the report. We probed Current
ACL is not CUDA here: CUDA may fail the probe on unregistered host pointers, but ACL returns Please keep the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ResolveAscendMemType()previously usedCHECK_ACL, treating anaclrtPointerGetAttributes()failure as a hard error (returning -1). As a result, registeringhost memory (hugepage / shm /
malloc) with the wildcard location"*"failed on Ascend. CUDAalready falls back when the wildcard probe cannot identify the memory; this change aligns Ascend
by treating the probe failure as host memory (
adxl::MEM_HOST). This matches the existing fixfor the heterogeneous RDMA transport (#1657).
Fixes #4054
Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Manual verification on Ascend 910B (bare
mooncake.engineTE path). The wildcard fallback fixfollows the same pattern already merged for the heterogeneous-RDMA transport (#1657).
Test results:
Checklist
./scripts/code_format.shAI Assistance Disclosure