Conversation
Signed-off-by: Schatten <czhengt@qq.com>
bitborne
requested review from
00fish0,
Aionw,
Icedcoco,
Libotry,
XucSh,
YiXR,
stmatengss and
ykwd
as code owners
September 16, 2026 15:49
Aionw
approved these changes
Sep 17, 2026
ykwd
approved these changes
Sep 17, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #3809. Move the three Mooncake Store HA backend reads of
MC_STORE_CLUSTER_IDinto a private, master-ownedHaClusterNamespaceConfigand register the variable in the common environment catalog.The existing explicit namespace argument still takes precedence without reading the environment. For an absent or empty variable, the default remains
mooncake_cluster; nonempty values are preserved verbatim, and each constructor resolves its own namespace. The Redis-disabled backend behavior and the independently owned client-metric label reader remain unchanged. No public API changes.This is a single-owner extraction, following the scope and private-config pattern of merged PRs #3872 and #4036.
Module
mooncake-store)mooncake-common)Type of Change
How Has This Been Tested?
Test commands:
cmake --build build --parallel 227 --target ha_cluster_namespace_config_test redis_snapshot_catalog_store_test high_availability_test mooncake_store_master_objects ctest --test-dir build -R '^(ha_cluster_namespace_config_test|redis_snapshot_catalog_store_test|high_availability_test)$' --output-on-failure ./scripts/code_format.sh --check --staged pre-commit run --files mooncake-common/include/environment_variables.h mooncake-store/src/CMakeLists.txt mooncake-store/src/config/ha_cluster_namespace_config.cpp mooncake-store/src/config/ha_cluster_namespace_config.h mooncake-store/src/ha/leadership/backends/etcd/etcd_leader_coordinator.cpp mooncake-store/src/ha/leadership/backends/redis/redis_leader_coordinator.cpp mooncake-store/src/ha/snapshot/catalog/backends/redis/redis_snapshot_catalog_store.cpp mooncake-store/tests/CMakeLists.txt mooncake-store/tests/ha_cluster_namespace_config_test.cpp mooncake-store/tests/ha/snapshot/catalog/backends/redis/redis_snapshot_catalog_store_test.cppTest results:
Checklist
./scripts/code_format.shNo documentation update: the supported environment behavior and API are unchanged.
AI Assistance Disclosure
Codex assisted with ownership analysis, implementation, RED-to-GREEN focused tests, build/format/hook verification, and review. The human submitter will review every changed line and is responsible for the change end to end.