chore(walker): backfill round_history + TW spec_support parity#183
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kwisschen
force-pushed
the
walker/round-history-backfill
branch
from
7982aa1 to
5c2cefb
Compare
Two complementary cleanups discovered when auditing whether walker-round discipline was being applied properly: 1. round_history backfill (PR #182 rule additions) - CN R38 `r38_locative_adjective_trailing_strip` — adds 相邻 to _TRAILING_VERB_DENYLIST_CN. Real user signal: issue #171. Cross-juris: TW already covers via existing trailing-strip pipeline. - US R10 `r10_through_hole_compound_np_synthesis` — adds bare-cardinal + through hole(s) compound-NP post-extension. Real user signal: issue #178 finding 1. Cross-juris: deferred per DR-1 (CJK 通孔 is a single token). Both marked fixtures_silenced: 0 honestly (rule additions only — corpus didn't exercise these patterns). 2. TW spec_support parity (mirror of PR #181 CN additions) - _TW_SPEC_SUPPORT_TRAILING_TOKENS += 抵靠 / 穿設 / 穿過 / 分別穿過 - PR #181 added the SC variants to CN from real CN reports (#174 / #175 / #176). All four are Traditional-compatible perforation / abutment verbs. Generalized per the user's standing instruction to mirror fixes across applicable jurisdictions. Discipline lesson: autoship walker fixes that don't silence corpus labels still need round_history entries — the cross-jurisdiction discipline pytest (tests/test_cross_jurisdiction_discipline.py) audits round_history for parity decisions. Updated triage-report SKILL.md (local) to enforce this going forward. Gates: - pytest: 2704 passed / 11 skipped - cross-jurisdiction discipline pytest: passes - US harness: 0 / 0 / 0 - CN harness: 0 / 0 / 0
kwisschen
force-pushed
the
walker/round-history-backfill
branch
from
5c2cefb to
5962c01
Compare
kwisschen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two complementary cleanups discovered when auditing whether walker-round discipline was being applied properly today.
1. round_history backfill (PR #182 rule additions)
Both marked `fixtures_silenced: 0` honestly — rule additions only; corpus didn't exercise these patterns.
2. TW spec_support parity (mirror of PR #181 CN additions)
`_TW_SPEC_SUPPORT_TRAILING_TOKENS` += `抵靠` / `穿設` / `穿過` / `分別穿過`.
PR #181 added the Simplified variants to CN from real CN reports (#174 / #175 / #176). All four are Traditional-Chinese-compatible perforation / abutment verbs commonly used in mechanical TIPO drafting. Generalized per the user's standing instruction to mirror fixes across applicable jurisdictions.
Discipline lesson
Autoship walker fixes that don't silence corpus labels still need `round_history` entries — the cross-jurisdiction discipline pytest (`tests/test_cross_jurisdiction_discipline.py`) audits `round_history` for parity decisions. Skipping the entry just because corpus stayed silent defeats that audit AND breaks forward-traceability of which mechanism was added when. Updated triage-report SKILL.md (local-only since .claude/ is gitignored) to enforce this going forward.
Gates