feat(FR-2762): add deployment preset detail view in VFolderDeployModal#7127
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 7.96% (-0.01% 🔻) |
1859/23350 |
| 🔴 | Branches | 7.16% (-0.01% 🔻) |
1187/16578 |
| 🔴 | Functions | 4.71% (+0.01% 🔼) |
297/6305 |
| 🔴 | Lines | 7.74% (-0% 🔻) |
1750/22611 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / DeploymentPresetDetailModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 4c5c5df
Review Summary — FR-2762I reviewed this PR against What looks good
Findings addressed (1 fix)MEDIUM — Missing error boundary around modal Suspense ( The Suspense block had no error boundary. If Fixed by wrapping the inner Suspense in Commit: Findings considered, not changed
Verification
|
4e339c7 to
d91e348
Compare
b2ca96c to
b0f5fb7
Compare
d91e348 to
c0f02a2
Compare
b0f5fb7 to
69c1ee3
Compare
c0f02a2 to
f4e1020
Compare
f4e1020 to
f4bc43d
Compare
d769590 to
adc2b11
Compare
f4bc43d to
d854b85
Compare
4bbc1f8 to
cc5c7ab
Compare
6d32d63 to
8d4f518
Compare
cc5c7ab to
c6a2244
Compare
c6a2244 to
1146cb6
Compare
8d4f518 to
c144ece
Compare
Add DeploymentPresetDetailModal and wire it into ServiceLauncherPageContent. The preset selector shows an info button (disabled until a preset is selected) that opens a read-only modal reusing DeploymentPresetDetailContent from FR-2761. Also adds the DeploymentPresetDetail i18n key to all 22 locales.
Prevent uncaught errors (network failure, deleted preset, permission) from bubbling up past the modal by pairing the inner Suspense with ErrorBoundaryWithNullFallback, matching the pattern used by AutoScalingRuleEditorModal and ModelCardDrawer.
…e service launcher wiring
…revent double query
cdb1aff to
4243c10
Compare
1146cb6 to
e93e2bf
Compare
…mage, show resource slots

Resolves #7122 (FR-2762)
Summary
DeploymentPresetDetailModalcomponent — read-only modal that fetches preset data via Relay and rendersDeploymentPresetDetailContentinside aBAIModalDeploymentPresetDetailContentcomponent — displays preset configuration inBAICardsections (Image, Cluster, Resources, Deployment Defaults)InfoCircleOutlined) next to the presetBAISelectinVFolderDeployModal, following theVFolderSelectpattern (BAIFlex+Space.Compact); disabled when no preset is selectedDeploymentPresetDetailModalas a sibling ofForm(not insideForm.Item) to prevent double Relay query caused byForm.Itemcloning its children on each renderrowId→idfield inServiceLauncherPageContentdeployment preset query (DeploymentRevisionPresetexposesid, notrowId)modelService.DeploymentPresetDetaili18n key to all 22 locale files