feat(FR-2762): add deployment preset detail button to VFolderDeployModal#7192
Closed
agatha197 wants to merge 1 commit intographite-base/7192from
Closed
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
5 tasks
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 7.97% (+0% 🔼) |
1859/23315 |
| 🔴 | Branches | 7.17% | 1187/16546 |
| 🔴 | Functions | 4.72% (+0.01% 🔼) |
297/6292 |
| 🔴 | Lines | 7.75% (+0% 🔼) |
1750/22582 |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 3f123ff
agatha197
changed the base branch from
04-28-feat_fr-2762_add_deployment_preset_detail_view_in_service_launcher
to
graphite-base/7192
Contributor
Author
|
Folded into #7127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7122 (FR-2762)
Summary
InfoCircleOutlined) next to the presetBAISelectinVFolderDeployModal, following theVFolderSelectpattern (BAIFlex+Space.Compact)DeploymentPresetDetailModalfor the currently selected presetrowId→idfield reference inServiceLauncherPageContentdeployment preset query (DeploymentRevisionPresetexposesid, notrowId)