Skip to content

feat(FR-2622): add bulk vfolder trash support on model card bulk deletion#7135

Open
agatha197 wants to merge 2 commits into04-22-test_fr-2652_add_e2e_tests_for_admin_model_card_deletion_with_folder_optionfrom
04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletion
Open

feat(FR-2622): add bulk vfolder trash support on model card bulk deletion#7135
agatha197 wants to merge 2 commits into04-22-test_fr-2652_add_e2e_tests_for_admin_model_card_deletion_with_folder_optionfrom
04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletion

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 28, 2026

Resolves #6841 (FR-2622)

Summary

Extends the FR-2622 single-card delete-with-folder UX to the bulk-delete flow on the Admin Model Card list page.

  • Add an opt-in "Also delete the associated model folders" checkbox to the bulk delete confirmation modal (matches the single-card modal copy/tooltip)
  • Wire a new Relay mutation bulkDeleteVfoldersV2 and call it after adminDeleteModelCardsV2 succeeds — passing the vfolderIds of the selected cards (skips cards with no vfolder)
  • After folders are moved to trash, replace the plain success message with a BAINotification whose action link navigates to Data > Trash (/admin-data?statusCategory=deleted). No name/id filter is applied in the bulk case — the trash tab is shown unfiltered, per design discussion
  • If the checkbox is left unchecked the existing BulkDeleteCompleted toast is preserved (no behavior change)
  • Add i18n keys to all 21 locales:
    • adminModelCard.AlsoDeleteModelFolders
    • adminModelCard.BulkDeleteModelCardsAndFoldersCompleted

Test plan

  • Bulk-delete N model cards without checkbox → toast {{count}} model card(s) have been deleted.
  • Bulk-delete N model cards with checkbox → notification with Go to Data > Trash link, navigates to /admin-data?statusCategory=deleted
  • Mix of cards with and without vfolders → only the cards that have vfolders are sent to bulkDeleteVfoldersV2
  • bash scripts/verify.sh — Relay / Lint / Format / TS all green

Checklist:

  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Contributor Author

agatha197 commented Apr 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.09% (-0.01% 🔻)
1858/22962
🔴 Branches
7.34% (-0.01% 🔻)
1187/16182
🔴 Functions
4.8% (-0% 🔻)
296/6169
🔴 Lines
7.86% (-0.01% 🔻)
1749/22247

Test suite run success

865 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from e32933e

@agatha197 agatha197 force-pushed the 04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletion branch from e643ef8 to cadbaf4 Compare April 28, 2026 10:45
@agatha197 agatha197 force-pushed the 04-22-test_fr-2652_add_e2e_tests_for_admin_model_card_deletion_with_folder_option branch from 5fa0945 to a6ec9e4 Compare April 28, 2026 10:45
@agatha197 agatha197 force-pushed the 04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletion branch from cadbaf4 to ae5238f Compare April 30, 2026 04:34
@agatha197 agatha197 force-pushed the 04-22-test_fr-2652_add_e2e_tests_for_admin_model_card_deletion_with_folder_option branch from a6ec9e4 to 9b7b330 Compare April 30, 2026 04:34
@agatha197 agatha197 force-pushed the 04-28-feat_fr-2622_add_bulk_vfolder_trash_support_on_model_card_bulk_deletion branch from ae5238f to e32933e Compare April 30, 2026 08:44
@agatha197 agatha197 force-pushed the 04-22-test_fr-2652_add_e2e_tests_for_admin_model_card_deletion_with_folder_option branch from 9b7b330 to 0fb1169 Compare April 30, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant