test(FR-2652): fix parallel interference and folder-dialog flakiness in delete spec#7162
Conversation
9 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
10 tasks
…in delete spec
- Add test.describe.configure({ mode: 'serial' }) to prevent within-file
parallelism under fullyParallel:true; filter results were empty under load
because newly created cards weren't indexed fast enough concurrently
- Extend toBeVisible timeout on post-cancel row assertions (5s → 15s)
- In createNewFolderViaPlus: increase or() timeout (5s → 10s), assert
"Current project changed successfully." after clicking Change Project so
the test fails fast if modelStoreProject data isn't loaded yet, and
increase folder-dialog visibility timeout (15s → 30s)
agatha197
force-pushed
the
04-28-test_fr-2622_add_e2e_tests_for_bulk_vfolder_trash_on_model_card_bulk_deletion
branch
from
fcb679d to
e21190c
Compare
agatha197
force-pushed
the
04-30-test_fr-2652_fix_parallel_interference_and_folder-dialog_flakiness_in_delete_spec
branch
from
f25c89e to
0af08bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6885 (FR-2652)
Stacked on top of #7137.
Summary
Fixes flakiness in
e2e/admin-model-card/admin-model-card-delete.spec.tsexposed under load:fullyParallel: trueset globally inplaywright.config.ts, tests within this file ran in parallel and the server occasionally indexed newly-created cards too slowly to satisfy the name filter (resulting in "No data" assertions). Addedtest.describe.configure({ mode: 'serial' })to the describe block so the tests share a deterministic ordering against the same backend.toBeVisiblewas tight enough to flake when the page was busy.createNewFolderViaPlusrobust against theChange ProjectPopconfirm path. TheonConfirmhandler inAdminModelCardSettingModalruns insidestartTransitionand silently no-ops whenmodelStoreProjectdata isn't loaded yet. The page object now:Change Project | folder dialograce timeout (5s → 10s).Change Project, asserts theCurrent project changed successfully.message — this fails fast (and clearly) when the data dependency isn't ready, instead of timing out later on the folder dialog.Test plan
pnpm exec playwright test e2e/admin-model-card/admin-model-card-delete.spec.ts— 10/10 passing in ~3.9 minutesfullyParallel: trueconfig — no parallel interference within the file